Changeset 60891

Timestamp:

10/02/2025 09:46:07 PM (12 months ago)

Author:

joedolson

Message:

Privacy: A11y: Show time of privacy request status change.

Add the date and time of privacy request status changes in the privacy requests table. Previously, human_time_diff() was used in the first 24 hours, and only the date after 24 hours. Change the output to display both date and time after 24 hours, using the format used for comments.

Props birgire, desrosj, afercia, xkon, tz-media, garrett-eclipse, sirlouen, sukhendu2002, sajjad67, fakhriaz, joedolson.
Fixes #44267.

Location:

trunk

Files:

• src/wp-admin/css/forms.css (modified) (1 diff)
• src/wp-admin/includes/class-wp-privacy-requests-table.php (modified) (2 diffs)
• tests/phpunit/tests/admin/wpPrivacyRequestsTable.php (modified) (1 diff)

trunk/src/wp-admin/css/forms.css

@@ -1454 +1454 @@
 }
 
+.privacy_requests .status-date {
+        display: block;
+        font-weight: 400;
+}
+
 .wp-privacy-request-form {
         clear: both;

trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php

@@ -462 +462 @@
 
                 if ( $timestamp ) {
-                        echo ' (' . $this->get_timestamp_as_date( $timestamp ) . ')';
+                        echo '<span class="status-date">' . $this->get_timestamp_as_date( $timestamp ) . '</span>';
                 }
 
@@ -488 +488 @@
                 }
 
-                return date_i18n( get_option( 'date_format' ), $timestamp );
+                return sprintf(
+                        /* translators: 1: privacy request date format, 2: privacy request time format. */
+                        __( '%1$s at %2$s' ),
+                        /* translators: privacy request date format. See https://www.php.net/manual/en/datetime.format.php */
+                        date_i18n( __( 'Y/m/d' ), $timestamp ),
+                        /* translators: privacy request time format. See https://www.php.net/manual/en/datetime.format.php */
+                        date_i18n( __( 'g:i a' ), $timestamp )
+                );
         }
 

trunk/tests/phpunit/tests/admin/wpPrivacyRequestsTable.php

@@ -210 +210 @@
                 $this->assertSame( $expected, $this->get_mocked_class_instance()->get_views() );
         }
+
+        /**
+         * Test the get_timestamp_as_date method formats timestamps correctly.
+         *
+         * @ticket 44267
+         *
+         * @covers WP_Privacy_Requests_Table::get_timestamp_as_date
+         */
+        public function test_get_timestamp_as_date() {
+                $table = $this->get_mocked_class_instance();
+
+                $reflection = new ReflectionClass( $table );
+                $method     = $reflection->getMethod( 'get_timestamp_as_date' );
+                $method->setAccessible( true );
+
+                $date_format = __( 'Y/m/d' );
+                $time_format = __( 'g:i a' );
+
+                $current_time = time();
+
+                $this->assertSame( '', $method->invoke( $table, '' ) );
+
+                // Test recent timestamp (less than 24 hours ago).
+                $recent_time = $current_time - HOUR_IN_SECONDS;
+                $result      = $method->invoke( $table, $recent_time );
+                $this->assertStringContainsString( 'ago', $result );
+
+                $old_time = $current_time - 2 * DAY_IN_SECONDS;
+                $result   = $method->invoke( $table, $old_time );
+
+                $date_part = date_i18n( $date_format, $old_time );
+                $time_part = date_i18n( $time_format, $old_time );
+
+                $this->assertStringContainsString( $date_part, $result );
+                $this->assertStringContainsString( 'at', $result );
+                $this->assertStringContainsString( $time_part, $result );
+        }
 }