Changeset 60913 for trunk/src/wp-content/themes/twentytwentyone/classes/class-twenty-twenty-one-dark-mode.php

Timestamp:

10/07/2025 11:32:04 PM (5 months ago)

Author:

westonruter

Message:

Bundled Themes: Use wp_print_inline_script_tag() when available and include sourceURL for JS.

Instead of manually constructing the markup for SCRIPT tags, leverage wp_print_inline_script_tag() when available to do the construction while also ensuring filters may inject additional attributes on the SCRIPT tags, such as nonce for CSP. When the function is not available (prior to WP 5.7), fall back to the manual markup construction.

This also adds the sourceURL comments to the inline scripts to facilitate debugging, per #63887.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/9416.

Follow-up to [60909], [60899].

Props debarghyabanerjee, westonruter, hbhalodia, peterwilsoncc, sabernhardt, poena.
See #63887, #59446.
Fixes #63806.

File:

• trunk/src/wp-content/themes/twentytwentyone/classes/class-twenty-twenty-one-dark-mode.php (modified) (1 diff)

trunk/src/wp-content/themes/twentytwentyone/classes/class-twenty-twenty-one-dark-mode.php

@@ -364 +364 @@
      */
     public function the_script() {
-        echo '<script>';
-        include get_template_directory() . '/assets/js/dark-mode-toggler.js'; // phpcs:ignore WPThemeReview.CoreFunctionality.FileInclude
-        echo '</script>';
+        $path = 'assets/js/dark-mode-toggler.js';
+        $js   = rtrim( file_get_contents( trailingslashit( get_template_directory() ) . $path ) );
+        $js  .= "\n//# sourceURL=" . esc_url_raw( trailingslashit( get_template_directory_uri() ) . $path );
+        if ( function_exists( 'wp_print_inline_script_tag' ) ) {
+            wp_print_inline_script_tag( $js );
+        } else {
+            printf( "<script>%s</script>\n", $js );
+        }
     }