Changeset 60928

Timestamp:

10/13/2025 09:48:42 PM (2 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use more meaningful variable names in Plugin Editor.

Per the ​Naming Conventions:

Don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.

Follow-up to [10879], [41721].

Props costdev, mukesh27.
See #63168.

File:

• trunk/src/wp-admin/plugin-editor.php (modified) (2 diffs)

trunk/src/wp-admin/plugin-editor.php

@@ -94 +94 @@
 
 if ( 'POST' === $_SERVER['REQUEST_METHOD'] ) {
-    $r = wp_edit_theme_plugin_file( wp_unslash( $_POST ) );
-    if ( is_wp_error( $r ) ) {
-        $edit_error = $r;
+    $edit_result = wp_edit_theme_plugin_file( wp_unslash( $_POST ) );
+
+    if ( is_wp_error( $edit_result ) ) {
+        $edit_error = $edit_result;
+
         if ( check_ajax_referer( 'edit-plugin_' . $file, 'nonce', false ) && isset( $_POST['newcontent'] ) ) {
             $posted_content = wp_unslash( $_POST['newcontent'] );
@@ -123 +125 @@
     // Get the extension of the file.
     if ( preg_match( '/\.([^.]+)$/', $real_file, $matches ) ) {
-        $ext = strtolower( $matches[1] );
+        $extension = strtolower( $matches[1] );
+
         // If extension is not in the acceptable list, skip it.
-        if ( ! in_array( $ext, $editable_extensions, true ) ) {
+        if ( ! in_array( $extension, $editable_extensions, true ) ) {
             wp_die( sprintf( '<p>%s</p>', __( 'Files of this type are not editable.' ) ) );
         }