Changeset 60930 for trunk/tests/phpunit/tests/script-modules/wpScriptModules.php

Timestamp:

10/14/2025 12:10:31 AM (12 months ago)

Author:

westonruter

Message:

Editor: Avoid enqueueing assets for blocks which do not render content.

This change prevents scripts, styles, and script modules from being enqueued for blocks that do not render any HTML content. This is common for hidden blocks or blocks like the Featured Image block when no image is present. This change reduces the amount of unused CSS and JavaScript on a page, improving performance.

A new filter, enqueue_empty_block_content_assets, is introduced to allow developers to override this behavior and enqueue assets for empty blocks if needed.

The implementation involves capturing the asset queues before and after a block is rendered. The newly enqueued assets are only merged if the block's rendered content is not empty. This is done recursively for nested blocks to ensure that assets for inner blocks are also not enqueued if a parent block is hidden.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/9213.

Props westonruter, aristath, peterwilsoncc, gziolo, krupajnanda, dd32, jorbin.
See #50328.
Fixes #63676.

File:

• trunk/tests/phpunit/tests/script-modules/wpScriptModules.php (modified) (1 diff)

trunk/tests/phpunit/tests/script-modules/wpScriptModules.php

@@ -1345 +1345 @@
 
         /**
+         * Tests that directly manipulating the queue works as expected.
+         *
+         * @ticket 63676
+         *
+         * @covers WP_Script_Modules::queue
+         * @covers WP_Script_Modules::dequeue
+         */
+        public function test_direct_queue_manipulation() {
+                $this->script_modules->register( 'foo', '/foo.js' );
+                $this->script_modules->register( 'bar', '/bar.js' );
+                $this->script_modules->register( 'baz', '/baz.js' );
+                $this->assertSame( array(), $this->script_modules->queue, 'Expected queue to be empty.' );
+                $this->script_modules->enqueue( 'foo' );
+                $this->script_modules->enqueue( 'foo' );
+                $this->script_modules->enqueue( 'bar' );
+                $this->assertSame( array( 'foo', 'bar' ), $this->script_modules->queue, 'Expected two deduplicated queued items.' );
+                $this->script_modules->queue = array( 'baz' );
+                $this->script_modules->enqueue( 'bar' );
+                $this->assertSame( array( 'baz', 'bar' ), $this->script_modules->queue, 'Expected queue updated via setter and enqueue method to have two items.' );
+                $this->script_modules->dequeue( 'baz' );
+                $this->script_modules->dequeue( 'bar' );
+                $this->assertSame( array(), $this->script_modules->queue, 'Expected queue to be empty after dequeueing both items.' );
+        }
+
+        /**
          * Gets registered script modules.
          *