Changeset 60934 for trunk/tests/phpunit/tests/theme.php

Timestamp:

10/15/2025 05:38:25 AM (12 months ago)

Author:

westonruter

Message:

Bundled Themes: Introduce stylesheet minification for core block themes.

This introduces a build process to provide minified stylesheets for the Twenty Twenty-Two and Twenty Twenty-Five themes. The built minified CSS is not committed to version control. When SCRIPT_DEBUG is disabled, the minified style.min.css file will be enqueued to improve performance, including reducing render-blocking resources as well as facilitating inlining. See #63007.

• Stylesheets are minified via the new core cssmin:themes Grunt task, which is automatically run as part of build:css.
• The same build process is added to the themes (via package.json and package-lock.json) with build and watch commands; the postcss and cssnano development dependencies are used to handle CSS minification.
• The functions.php in each theme is updated to enqueue style.min.css unless SCRIPT_DEBUG is enabled, in which case style.css is enqueued.
• A notice comment is added to style.css to warn against editing the stylesheet since the minified version will likely be served instead.
• A new contributing.txt file is added to each theme to document the build process for developers.
• The test-and-zip-default-themes GitHub workflow is updated to install npm dependencies and build the minified assets before packaging the themes.
• New PHPUnit tests are added to verify version number consistency across style.css, readme.txt, package.json, and package-lock.json files in default themes.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10081.

Props b1ink0, westonruter, shyamgadde, jonsurrell, sabernhardt, jorbin, peterwilsoncc, poena.
Fixes #63012.

File:

• trunk/tests/phpunit/tests/theme.php (modified) (2 diffs)

trunk/tests/phpunit/tests/theme.php

@@ -315 +315 @@
          * @ticket 48566
          *
-         * @dataProvider data_year_in_readme
+         * @dataProvider data_provider_default_themes
          */
         public function test_year_in_readme( $theme ) {
@@ -337 +337 @@
         }
 
-        public function data_year_in_readme() {
-                return array_map(
-                        static function ( $theme ) {
-                                return array( $theme );
-                        },
-                        $this->default_themes
-                );
+        /**
+         * Data provider.
+         *
+         * @return array<string, array{ theme: string }>
+         */
+        public function data_provider_default_themes(): array {
+                $data = array();
+                foreach ( $this->default_themes as $default_theme ) {
+                        $data[ $default_theme ] = array( 'theme' => $default_theme );
+                }
+                return $data;
+        }
+
+        /**
+         * Tests that the version number in style.css, readme.txt, and package.json all match.
+         *
+         * @ticket 63012
+         *
+         * @dataProvider data_provider_default_themes
+         */
+        public function test_version_consistency_in_package_json( string $theme ) {
+                $wp_theme = wp_get_theme( $theme );
+
+                $path_to_style_css = $wp_theme->get_theme_root() . '/' . $wp_theme->get_stylesheet() . '/style.css';
+                $this->assertFileExists( $path_to_style_css );
+                $this->assertSame( 1, preg_match( '/^Version: (\d+\.\d+(?:\.\d+)?)$/m', file_get_contents( $path_to_style_css ), $matches ), 'Expected Version in style.css' );
+                $style_version = $matches[1];
+
+                // Version in style.css does not use patch versions, so supply one of 0.
+                $version_with_patch = $matches[1];
+                if ( 1 === substr_count( $version_with_patch, '.' ) ) {
+                        $version_with_patch .= '.0';
+                }
+
+                $package_files         = array( 'package.json', 'package-lock.json' );
+                $present_package_files = array();
+                foreach ( $package_files as $package_file ) {
+                        $path_to_package_json = $wp_theme->get_theme_root() . '/' . $wp_theme->get_stylesheet() . '/' . $package_file;
+                        if ( file_exists( $path_to_package_json ) ) {
+                                $present_package_files[] = $package_file;
+
+                                $data = json_decode( file_get_contents( $path_to_package_json ), true );
+                                $this->assertIsArray( $data, "Expected $package_file to be an array." );
+                                $this->assertArrayHasKey( 'name', $data, "Expected name key in $package_file." );
+                                $this->assertSame( $theme, $data['name'], "Expected name field to be the theme slug in $package_file." );
+                                $this->assertArrayHasKey( 'version', $data, "Expected version key in $package_file." );
+                                $this->assertSame( $version_with_patch, $data['version'], "Expected version from style.css to match version in $package_file." );
+
+                                if ( 'package-lock.json' === $package_file && isset( $data['packages'][''] ) ) {
+                                        $this->assertArrayHasKey( 'version', $data['packages'][''], "Expected version key in packages[''] in package-lock.json." );
+                                        $this->assertSame( $version_with_patch, $data['packages']['']['version'], "Expected version from style.css to match packages[''].version in package-lock.json." );
+                                }
+                        }
+                }
+                if ( count( $present_package_files ) > 0 ) {
+                        $this->assertCount( 2, $present_package_files, 'Expected package-lock.json to be present when package.json is present, and vice versa.' );
+                }
+
+                // TODO: The themes twentyfifteen, twentysixteen, and twentyseventeen lack a Stable Tag in the readme.txt.
+                $path_to_readme_txt = $wp_theme->get_theme_root() . '/' . $wp_theme->get_stylesheet() . '/readme.txt';
+                $this->assertFileExists( $path_to_readme_txt );
+                if ( 1 === preg_match( '/^Stable [Tt]ag: (\d+\.\d+(?:\.\d+)?)$/m', file_get_contents( $path_to_readme_txt ), $matches ) ) {
+                        $readme_version = $matches[1];
+                        $this->assertSame( $style_version, $readme_version, 'Expected version in style.css and stable tag in readme.txt to match.' );
+                }
         }