Changeset 60937

Timestamp:

10/15/2025 08:28:51 PM (5 weeks ago)

Author:

kadamwhite

Message:

REST API: Allow comment content to be updated to empty when allow_empty_comment filter returns true

This filter was already respected during comment creation, but not updates. This was inconsistent between POST and PUT, and prevented erasing content of moderated comments via the API without deleting the entire object.

Props adamsilverstein, kadamwhite, davidbaumwald, mukesh27, timothyblynjacobs.
Fixes #64049.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (2 diffs)
• tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -860 +860 @@
                 return $prepared_args;
             }
-
-            if ( isset( $prepared_args['comment_content'] ) && empty( $prepared_args['comment_content'] ) ) {
+            if ( ! $this->check_is_comment_content_allowed( $prepared_args ) ) {
                 return new WP_Error(
                     'rest_comment_content_invalid',
@@ -1904 +1903 @@
      */
     protected function check_is_comment_content_allowed( $prepared_comment ) {
+        if ( ! isset( $prepared_comment['comment_content'] ) ) {
+            return true;
+        }
+
         $check = wp_parse_args(
             $prepared_comment,

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -2494 +2494 @@
     }
 
+    /**
+     * @ticket 64049
+     */
+    public function test_update_item_no_content_allow_empty_comment_filter() {
+        $post_id = self::factory()->post->create();
+
+        wp_set_current_user( self::$admin_id );
+
+        $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/comments/%d', self::$approved_id ) );
+        $request->set_param( 'author_email', 'another@email.com' );
+
+        // Sending a request without content is fine.
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertSame( 200, $response->get_status() );
+
+        // Sending a request with empty comment content is also fine.
+        $request->set_param( 'author_email', 'yetanother@email.com' );
+        $request->set_param( 'content', '' );
+        add_filter( 'allow_empty_comment', '__return_true' );
+        $response = rest_get_server()->dispatch( $request );
+        remove_filter( 'allow_empty_comment', '__return_true' );
+        $this->assertSame( 200, $response->get_status() );
+    }
+
     public function test_update_item_no_change() {
         $comment = get_comment( self::$approved_id );