Changeset 60941 for trunk/src/wp-includes/user.php

Timestamp:

10/15/2025 11:56:57 PM (4 months ago)

Author:

peterwilsoncc

Message:

Users: Add caching to count_many_users_posts().

Introduces object caching to the count_many_users_posts() function.

Argument equivalency is checked prior to generating the cache key to ensure that the same cache is hit regardless of array order for users and post types. For example count_many_users_posts( [ 1, 2 ] ) will hit the same cache as count_many_users_posts( [ 2, 1 ] ).

Props adamsilverstein, flixos90, kalpeshh, rollybueno, sachinrajcp123, shailu25, sirlouen, spacedmonkey, westonruter, wildworks.
Fixes #63045.

File:

• trunk/src/wp-includes/user.php (modified) (3 diffs)

trunk/src/wp-includes/user.php

@@ -650 +650 @@
  *
  * @since 3.0.0
+ * @since 6.9.0 The results are now cached.
  *
  * @global wpdb $wpdb WordPress database abstraction object.
@@ -656 +657 @@
  * @param string|string[] $post_type   Optional. Single post type or array of post types to check. Defaults to 'post'.
  * @param bool            $public_only Optional. Only return counts for public posts.  Defaults to false.
- * @return string[] Amount of posts each user has written, as strings, keyed by user ID.
+ * @return array<int, string> Amount of posts each user has written, as strings, keyed by user ID.
  */
 function count_many_users_posts( $users, $post_type = 'post', $public_only = false ) {
@@ -683 +684 @@
     }
 
-    $userlist = implode( ',', array_map( 'absint', $users ) );
-    $where    = get_posts_by_author_sql( $post_type, true, null, $public_only );
-
-    $result = $wpdb->get_results( "SELECT post_author, COUNT(*) FROM $wpdb->posts $where AND post_author IN ($userlist) GROUP BY post_author", ARRAY_N );
-
-    $count = array_fill_keys( $users, 0 );
-    foreach ( $result as $row ) {
-        $count[ $row[0] ] = $row[1];
+    // Cleanup the users array. Remove duplicates and sort for consistent ordering.
+    $users = array_unique( array_filter( array_map( 'intval', $users ) ) );
+    sort( $users );
+
+    // Cleanup the post type argument. Remove duplicates and sort for consistent ordering.
+    $post_type = array_unique( (array) $post_type );
+    sort( $post_type );
+
+    $userlist    = implode( ',', $users );
+    $where       = get_posts_by_author_sql( $post_type, true, null, $public_only );
+    $query       = "SELECT post_author, COUNT(*) FROM $wpdb->posts $where AND post_author IN ($userlist) GROUP BY post_author";
+    $cache_key   = 'count_many_users_posts:' . md5( $query );
+    $cache_salts = array( wp_cache_get_last_changed( 'posts' ), wp_cache_get_last_changed( 'users' ) );
+    $count       = wp_cache_get_salted( $cache_key, 'post-queries', $cache_salts );
+
+    if ( false === $count ) {
+        $where  = get_posts_by_author_sql( $post_type, true, null, $public_only );
+        $result = $wpdb->get_results( "SELECT post_author, COUNT(*) FROM $wpdb->posts $where AND post_author IN ($userlist) GROUP BY post_author", ARRAY_N );
+
+        $count = array_fill_keys( $users, 0 );
+        foreach ( $result as $row ) {
+            $count[ $row[0] ] = $row[1];
+        }
+
+        wp_cache_set_salted( $cache_key, $count, 'post-queries', $cache_salts, HOUR_IN_SECONDS );
     }