Changeset 60948 for trunk/src/wp-includes/class-wp-styles.php

Timestamp:

10/16/2025 07:59:11 PM (3 months ago)

Author:

joedolson

Message:

General: Remove support for IE conditional comments.

Remove the ability to enqueue scripts and styles wrapped in IE conditional comment tags. Conditional comment support was removed from IE in version 10 in 2012, and no core supported browser renders them in any way. IE9 has global usage approaching zero. WordPress dropped support for IE10 and below in version 4.8.

Patch adds a deprecation notice if the conditional data argument is added. Scripts and styles are not printed, and neither are their dependencies if they are not required by other non-conditional scripts. Conditional dependencies are removed from core enqueues.

Props jonsurrell, joedolson, shailu25, siliconforks, dmsnell, sabernhardt, rollybueno.
Fixes #63821.

File:

• trunk/src/wp-includes/class-wp-styles.php (modified) (5 diffs)

trunk/src/wp-includes/class-wp-styles.php

@@ -155 +155 @@
 
         $obj = $this->registered[ $handle ];
-
+        if ( $obj->extra['conditional'] ?? false ) {
+
+            return false;
+        }
         if ( null === $obj->ver ) {
             $ver = '';
@@ -166 +169 @@
         }
 
-        $src                   = $obj->src;
-        $ie_conditional_prefix = '';
-        $ie_conditional_suffix = '';
-        $conditional           = isset( $obj->extra['conditional'] ) ? $obj->extra['conditional'] : '';
-
-        if ( $conditional ) {
-            $ie_conditional_prefix = "<!--[if {$conditional}]>\n";
-            $ie_conditional_suffix = "<![endif]-->\n";
-        }
-
+        $src          = $obj->src;
         $inline_style = $this->print_inline_style( $handle, false );
 
@@ -190 +184 @@
 
         if ( $this->do_concat ) {
-            if ( $this->in_default_dir( $src ) && ! $conditional && ! isset( $obj->extra['alt'] ) ) {
+            if ( $this->in_default_dir( $src ) && ! isset( $obj->extra['alt'] ) ) {
                 $this->concat         .= "$handle,";
                 $this->concat_version .= "$handle$ver";
@@ -280 +274 @@
 
         if ( $this->do_concat ) {
-            $this->print_html .= $ie_conditional_prefix;
             $this->print_html .= $tag;
             if ( $inline_style_tag ) {
                 $this->print_html .= $inline_style_tag;
             }
-            $this->print_html .= $ie_conditional_suffix;
         } else {
-            echo $ie_conditional_prefix;
             echo $tag;
             $this->print_inline_style( $handle );
-            echo $ie_conditional_suffix;
         }
 
@@ -372 +362 @@
 
         return true;
+    }
+
+    /**
+     * Overrides the add_data method from WP_Dependencies, to allow unsetting dependencies for conditional styles.
+     *
+     * @since 6.9.0
+     *
+     * @param string $handle Name of the item. Should be unique.
+     * @param string $key    The data key.
+     * @param mixed  $value  The data value.
+     * @return bool True on success, false on failure.
+     */
+    public function add_data( $handle, $key, $value ) {
+        if ( ! isset( $this->registered[ $handle ] ) ) {
+            return false;
+        }
+
+        if ( 'conditional' === $key ) {
+            $this->registered[ $handle ]->deps = array();
+        }
+
+        return parent::add_data( $handle, $key, $value );
     }