Changeset 60974

Timestamp:

10/19/2025 12:32:32 AM (less than one hour ago)

Author:

dmsnell

Message:

HTML API: Rely on assertEqualHTML in wp_rel_nofollow() tests.

As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces strict string-equality checks with semantic checks via assertEqualHTML() for more-direct assertions.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/9251
Discussed in https://core.trac.wordpress.org/ticket/63694

Props dmsnell, jonsurrell.
See #63694

File:

• trunk/tests/phpunit/tests/formatting/wpRelNofollow.php (modified) (4 diffs)

trunk/tests/phpunit/tests/formatting/wpRelNofollow.php

@@ -13 +13 @@
     public function test_add_no_follow() {
         $content  = '<p>This is some cool <a href="/">Code</a></p>';
-        $expected = '<p>This is some cool <a href=\"/\" rel=\"nofollow\">Code</a></p>';
-        $this->assertSame( $expected, wp_rel_nofollow( $content ) );
+        $expected = '<p>This is some cool <a href="/" rel="nofollow">Code</a></p>';
+        $this->assertEqualHTML( $expected, stripslashes( wp_rel_nofollow( $content ) ) );
     }
 
@@ -22 +22 @@
     public function test_convert_no_follow() {
         $content  = '<p>This is some cool <a href="/" rel="weird">Code</a></p>';
-        $expected = '<p>This is some cool <a href=\"/\" rel=\"weird nofollow\">Code</a></p>';
-        $this->assertSame( $expected, wp_rel_nofollow( $content ) );
+        $expected = '<p>This is some cool <a href="/" rel="weird nofollow">Code</a></p>';
+        $this->assertEqualHTML( $expected, stripslashes( wp_rel_nofollow( $content ) ) );
     }
 
@@ -31 +31 @@
      */
     public function test_wp_rel_nofollow( $input, $output, $expect_deprecation = false ) {
-        $this->assertSame( wp_slash( $output ), wp_rel_nofollow( $input ) );
+        $this->assertEqualHTML( $output, stripslashes( wp_rel_nofollow( $input ) ) );
     }
 
@@ -81 +81 @@
     public function test_append_no_follow_with_valueless_attribute() {
         $content  = '<p>This is some cool <a href="demo.com" download rel="hola">Code</a></p>';
-        $expected = '<p>This is some cool <a href=\"demo.com\" download rel=\"hola nofollow\">Code</a></p>';
-        $this->assertSame( $expected, wp_rel_nofollow( $content ) );
+        $expected = '<p>This is some cool <a href="demo.com" download rel="hola nofollow">Code</a></p>';
+        $this->assertEqualHTML( $expected, stripslashes( wp_rel_nofollow( $content ) ) );
     }
 }