Changeset 60976 for trunk/src/wp-admin/users.php

Timestamp:

10/19/2025 05:18:55 PM (3 months ago)

Author:

johnjamesjacoby

Message:

Networks and Sites: prevent a PHP error in wp-admin/network/site-users.php.

This change brings the multisite specific promote user action up-to-speed with the single-site one, by adding:

• capability checks where appropriate
• a none check on $role to set it to an empty string

It also updates the inline documentation of the single-site promote user action in users.php, to match the suggested additions to the multisite file.

Props ignatiusjeroe, jeremyfelt, johnjamesjacoby, pratiklondhe, shanemuir, sudipatel007, techpartho.

Fixes #61100.

File:

• trunk/src/wp-admin/users.php (modified) (2 diffs)

trunk/src/wp-admin/users.php

@@ -123 +123 @@
         $role           = $_REQUEST['new_role'];
 
-        // Mocking the `none` role so we are able to save it to the database
+        // Mock `none` as editable role.
         $editable_roles['none'] = array(
             'name' => __( '— No role for this site —' ),
@@ -163 +163 @@
 
             $user = get_userdata( $id );
+
+            // If $role is empty, none will be set.
             $user->set_role( $role );
         }