Changeset 60977 for trunk/src/wp-admin/user-edit.php

Timestamp:

10/19/2025 05:40:13 PM (3 months ago)

Author:

johnjamesjacoby

Message:

Networks and Sites: remove email address check when attempting to demote a Super Admin.

This change ensures that a capable Super Admin is allowed to manage global Users as intended, and removes an invisible & undocumented restriction (that was easily bypassed anyways).

It also adds 1 multisite unit test to confirm the intended behavior

Props flixos90, johnjamesjacoby, Mista-Flo.

Fixes #39170.

File:

• trunk/src/wp-admin/user-edit.php (modified) (1 diff)

trunk/src/wp-admin/user-edit.php

@@ -472 +472 @@
                     <?php endif; // End if ! IS_PROFILE_PAGE. ?>
 
-                    <?php if ( is_multisite() && is_network_admin() && ! IS_PROFILE_PAGE && current_user_can( 'manage_network_options' ) && ! isset( $super_admins ) ) : ?>
+                    <?php if ( is_multisite() && is_network_admin() && ! IS_PROFILE_PAGE && ! isset( $super_admins ) ) : ?>
                         <tr class="user-super-admin-wrap">
                             <th><?php _e( 'Super Admin' ); ?></th>
                             <td>
-                                <?php if ( 0 !== strcasecmp( $profile_user->user_email, get_site_option( 'admin_email' ) ) || ! is_super_admin( $profile_user->ID ) ) : ?>
-                                    <p><label><input type="checkbox" id="super_admin" name="super_admin"<?php checked( is_super_admin( $profile_user->ID ) ); ?> /> <?php _e( 'Grant this user super admin privileges for the Network.' ); ?></label></p>
-                                <?php else : ?>
-                                    <p><?php _e( 'Super admin privileges cannot be removed because this user has the network admin email.' ); ?></p>
-                                <?php endif; ?>
+                                <p><label><input type="checkbox" id="super_admin" name="super_admin"<?php checked( is_super_admin( $profile_user->ID ) ); ?> /> <?php _e( 'Grant this user super admin privileges for the Network.' ); ?></label></p>
                             </td>
                         </tr>