Changeset 60977 for trunk/tests/phpunit/tests/user/multisite.php

Timestamp:

10/19/2025 05:40:13 PM (3 months ago)

Author:

johnjamesjacoby

Message:

Networks and Sites: remove email address check when attempting to demote a Super Admin.

This change ensures that a capable Super Admin is allowed to manage global Users as intended, and removes an invisible & undocumented restriction (that was easily bypassed anyways).

It also adds 1 multisite unit test to confirm the intended behavior

Props flixos90, johnjamesjacoby, Mista-Flo.

Fixes #39170.

File:

• trunk/tests/phpunit/tests/user/multisite.php (modified) (1 diff)

trunk/tests/phpunit/tests/user/multisite.php

@@ -449 +449 @@
         $wp_roles->remove_role( $role );
     }
+
+    /**
+     * @ticket 39170
+     */
+    public function test_revoke_super_admin_with_network_email() {
+        if ( isset( $GLOBALS['super_admins'] ) ) {
+            $old_global = $GLOBALS['super_admins'];
+            unset( $GLOBALS['super_admins'] );
+        }
+
+        $old_network_email = get_site_option( 'admin_email' );
+        $email_address     = 'superadmin333@example.org';
+
+        $user_id = self::factory()->user->create(
+            array(
+                'user_email' => $email_address,
+            )
+        );
+
+        grant_super_admin( $user_id );
+        update_site_option( 'admin_email', $email_address );
+
+        $result = revoke_super_admin( $user_id );
+
+        update_site_option( 'admin_email', $old_network_email );
+
+        if ( isset( $old_global ) ) {
+            $GLOBALS['super_admins'] = $old_global;
+        }
+
+        $this->assertTrue( $result );
+    }
 }