Changeset 61002 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

Timestamp:

10/21/2025 03:31:55 AM (11 months ago)

Author:

peterwilsoncc

Message:

REST API: Improve performance of X-WP-Total/X-WP-TotalPages queries.

Improve the performance of fallback queries to determine the total number of objects available on various REST endpoints for out of bounds queries.

The database queries are modified to return the minimum amount of data required for determining the count and bypass priming of meta a term caches where appropriate.

Props adamsilverstein, joehoyle, johnbillion, jorbin, kadamwhite, spacedmonkey, sukhendu2002, westonruter.
Fixes #62801.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -324 +324 @@
 
                 if ( $total_comments < 1 ) {
-                        // Out-of-bounds, run the query again without LIMIT for total count.
+                        // Out-of-bounds, run the query without pagination/offset to get the total count.
                         unset( $prepared_args['number'], $prepared_args['offset'] );
 
-                        $query                    = new WP_Comment_Query();
-                        $prepared_args['count']   = true;
-                        $prepared_args['orderby'] = 'none';
+                        $query                                      = new WP_Comment_Query();
+                        $prepared_args['count']                     = true;
+                        $prepared_args['orderby']                   = 'none';
+                        $prepared_args['update_comment_meta_cache'] = false;
 
                         $total_comments = $query->query( $prepared_args );