Changeset 61008 for trunk/tests/phpunit/tests/blocks/register.php

Timestamp:

10/21/2025 05:59:38 AM (3 months ago)

Author:

westonruter

Message:

Script Loader: Load block styles on demand in classic themes via the template enhancement output buffer.

• This applies in classic themes when a site has not opted out of the template enhancement buffer by filtering wp_should_output_buffer_template_for_enhancement off.
• Both should_load_separate_core_block_assets and should_load_block_assets_on_demand are filtered on, as otherwise they are only enabled by default in block themes.
• Any style enqueued after wp_head and printed via print_late_styles() will get hoisted up to be inserted right after the wp-block-library inline style in the HEAD.
• The result is a >10% benchmarked improvement in LCP for core classic themes due to a ~100KB reduction in the amount of CSS unconditionally being served with every page load.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10288

Follow-up to [60936].

Props sjapaget, westonruter, peterwilsoncc, dmsnell, mindctrl.
See #43258.
Fixes #64099.

File:

• trunk/tests/phpunit/tests/blocks/register.php (modified) (6 diffs)

trunk/tests/phpunit/tests/blocks/register.php

@@ -12 +12 @@
 
     /**
+     * @var WP_Scripts|null
+     */
+    protected $original_wp_scripts;
+
+    /**
+     * @var WP_Styles|null
+     */
+    protected $original_wp_styles;
+
+    /**
      * ID for a test post.
      *
@@ -46 +56 @@
      */
     public function render_stub() {}
+
+    /**
+     * Set up.
+     */
+    public function set_up() {
+        parent::set_up();
+
+        global $wp_scripts, $wp_styles;
+        $this->original_wp_scripts = $wp_scripts;
+        $this->original_wp_styles  = $wp_styles;
+        $wp_scripts                = null;
+        $wp_styles                 = null;
+        wp_scripts();
+        wp_styles();
+    }
 
     /**
@@ -67 +92 @@
             }
         }
+
+        global $wp_scripts, $wp_styles;
+        $wp_scripts = $this->original_wp_scripts;
+        $wp_styles  = $this->original_wp_styles;
 
         parent::tear_down();
@@ -1004 +1033 @@
         );
 
+        // Register the styles not included in the metadata above.
+        $metadata = array(
+            'file'      => DIR_TESTDATA . '/blocks/notice/block.json',
+            'name'      => 'tests/notice',
+            'style'     => 'file:./block.css',
+            'viewStyle' => 'file:./block-view.css',
+        );
+        $this->assertSame( 'tests-notice-style', register_block_style_handle( $metadata, 'style' ), 'Style handle is expected to be tests-notice-style' );
+        $this->assertSame( 'tests-notice-view-style', register_block_style_handle( $metadata, 'viewStyle' ), 'View style handle is expected to be tests-notice-view-style' );
+        $this->assertTrue( wp_style_is( 'tests-notice-style', 'registered' ), 'Expected "tests-notice-style" style to be registered.' );
+        $this->assertTrue( wp_style_is( 'tests-notice-view-style', 'registered' ), 'Expected "tests-notice-view-style" style to be registered.' );
+
         $this->assertInstanceOf( 'WP_Block_Type', $result );
         $this->assertSame( 2, $result->api_version );
@@ -1122 +1163 @@
         $this->assertSame(
             wp_normalize_path( realpath( DIR_TESTDATA . '/blocks/notice/block.css' ) ),
-            wp_normalize_path( wp_styles()->get_data( 'tests-test-block-style', 'path' ) )
+            wp_normalize_path( wp_styles()->get_data( 'tests-notice-style', 'path' ) )
         );
 
@@ -1128 +1169 @@
         $this->assertSame(
             wp_normalize_path( realpath( DIR_TESTDATA . '/blocks/notice/block-view.css' ) ),
-            wp_normalize_path( wp_styles()->get_data( 'tests-test-block-view-style', 'path' ) ),
+            wp_normalize_path( wp_styles()->get_data( 'tests-notice-view-style', 'path' ) ),
             'viewStyle asset path is not correct'
         );