Changeset 61008 for trunk/tests/phpunit/tests/blocks/registerCoreBlockStyleHandles.php

Timestamp:

10/21/2025 05:59:38 AM (12 months ago)

Author:

westonruter

Message:

Script Loader: Load block styles on demand in classic themes via the template enhancement output buffer.

• This applies in classic themes when a site has not opted out of the template enhancement buffer by filtering wp_should_output_buffer_template_for_enhancement off.
• Both should_load_separate_core_block_assets and should_load_block_assets_on_demand are filtered on, as otherwise they are only enabled by default in block themes.
• Any style enqueued after wp_head and printed via print_late_styles() will get hoisted up to be inserted right after the wp-block-library inline style in the HEAD.
• The result is a >10% benchmarked improvement in LCP for core classic themes due to a ~100KB reduction in the amount of CSS unconditionally being served with every page load.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10288

Follow-up to [60936].

Props sjapaget, westonruter, peterwilsoncc, dmsnell, mindctrl.
See #43258.
Fixes #64099.

File:

• trunk/tests/phpunit/tests/blocks/registerCoreBlockStyleHandles.php (modified) (5 diffs)

trunk/tests/phpunit/tests/blocks/registerCoreBlockStyleHandles.php

@@ -16 +16 @@
 
         /**
-         * @var WP_Styles
+         * @var WP_Styles|null
          */
-        private $old_wp_styles;
+        protected $original_wp_styles;
 
         /**
@@ -33 +33 @@
                 parent::set_up();
 
-                $this->old_wp_styles = $GLOBALS['wp_styles'];
+                global $wp_styles;
+                $this->original_wp_styles = $wp_styles;
+                $wp_styles                = null;
+                wp_styles();
 
                 $this->includes_url = includes_url();
 
                 remove_action( 'wp_default_styles', 'wp_default_styles' );
-
-                if ( empty( $GLOBALS['wp_styles'] ) ) {
-                        $GLOBALS['wp_styles'] = null;
-                }
         }
 
         public function tear_down() {
-                $GLOBALS['wp_styles'] = $this->old_wp_styles;
+                global $wp_styles;
+                $wp_styles = $this->original_wp_styles;
 
                 add_action( 'wp_default_styles', 'wp_default_styles' );
@@ -57 +57 @@
          * @dataProvider data_block_data
          *
+         * @covers ::register_core_block_style_handles
+         * @covers ::wp_should_load_separate_core_block_assets
+         *
          * @param string $name   The block name.
          * @param array  $schema The block's schema.
          */
         public function test_wp_should_load_separate_core_block_assets_false( $name, $schema ) {
+                add_filter( 'should_load_separate_core_block_assets', '__return_false' );
+                $this->assertFalse( wp_should_load_separate_core_block_assets(), 'Core blocks are not expected to load separate assets' );
                 register_core_block_style_handles();
 
@@ -79 +84 @@
          * @dataProvider data_block_data
          *
+         * @covers ::register_core_block_style_handles
+         * @covers ::wp_should_load_separate_core_block_assets
+         *
          * @param string $name   The block name.
          * @param array  $schema The block's schema.
@@ -84 +92 @@
         public function test_wp_should_load_separate_core_block_assets_true( $name, $schema ) {
                 add_filter( 'should_load_separate_core_block_assets', '__return_true' );
+                $this->assertTrue( wp_should_load_separate_core_block_assets(), 'Core assets are expected to load separately' );
                 register_core_block_style_handles();