Changeset 61025

Timestamp:

10/21/2025 12:45:03 PM (11 months ago)

Author:

jorbin

Message:

Mail: Improve tests for mail embeds

Use a dataProvider to ensure that embeds works with multiple different shaped arrays.

Follow-up to [60698].

Props sirlouen, dmsnell, jorbin.
Fixes #28059.

File:

• trunk/tests/phpunit/tests/pluggable/wpMail.php (modified) (2 diffs)

trunk/tests/phpunit/tests/pluggable/wpMail.php

@@ -557 +557 @@
          *
          * @ticket 28059
-         */
-        public function test_wp_mail_can_send_embedded_images() {
-                $embeds = array(
-                        'canola' => DIR_TESTDATA . '/images/canola.jpg',
-                        DIR_TESTDATA . '/images/test-image-2.gif',
-                        DIR_TESTDATA . '/images/avif-lossy.avif',
-                );
-
+         *
+         * @dataProvider data_wp_mail_can_send_embedded_images
+         *
+         * @param string[] $embeds The embeds to send.
+         */
+        public function test_wp_mail_can_send_embedded_images( $embeds ) {
                 $message = '';
                 foreach ( $embeds as $key => $path ) {
@@ -592 +590 @@
 
         /**
+         * Data provider for test_wp_mail_can_send_embedded_images().
+         *
+         * @return array
+         */
+        public static function data_wp_mail_can_send_embedded_images() {
+                return array(
+                        'Mixed Array Embeds'       => array(
+                                'embeds' => array(
+                                        'canola' => DIR_TESTDATA . '/images/canola.jpg',
+                                        DIR_TESTDATA . '/images/test-image-2.gif',
+                                        DIR_TESTDATA . '/images/avif-lossy.avif',
+                                ),
+                        ),
+                        'Associative Array Embeds' => array(
+                                'embeds' => array(
+                                        'canola'       => DIR_TESTDATA . '/images/canola.jpg',
+                                        'test-image-2' => DIR_TESTDATA . '/images/test-image-2.gif',
+                                        'avif-lossy'   => DIR_TESTDATA . '/images/avif-lossy.avif',
+                                ),
+                        ),
+                        'Indexed Array Embeds'     => array(
+                                'embeds' => array(
+                                        DIR_TESTDATA . '/images/canola.jpg',
+                                        DIR_TESTDATA . '/images/test-image-2.gif',
+                                        DIR_TESTDATA . '/images/avif-lossy.avif',
+                                ),
+                        ),
+                );
+        }
+
+        /**
          * Tests that wp_mail() can send embedded images as a multiple line string.
          *