Changeset 61048

Timestamp:

10/22/2025 04:28:33 PM (4 months ago)

Author:

johnjamesjacoby

Message:

Query: Prevent querying for all terms in WP_Term_Query when include is set to [0].

This change brings the include parameter of WP_Term_Query up-to-speed with the include and __in parameters of other _Query classes, so that sending a value of [0] will not unintentionally perform an unbound query that returns all Terms.

It also introduces 3 new unit tests (for the Post, Term, and User query classes) to compare this behavior between them and ensure they remain consistent going forward.

Props audrasjb, hareesh-pillai, hellofromTonya, johnjamesjacoby, mukesh27.

Fixes #47719.

Location:

trunk

Files:

• src/wp-includes/class-wp-term-query.php (modified) (2 diffs)
• tests/phpunit/tests/post/query.php (modified) (1 diff)
• tests/phpunit/tests/term/query.php (modified) (1 diff)
• tests/phpunit/tests/user/query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-term-query.php

@@ -471 +471 @@
         $include      = $args['include'];
 
-        $inclusions = '';
         if ( ! empty( $include ) ) {
             $exclude      = '';
             $exclude_tree = '';
             $inclusions   = implode( ',', wp_parse_id_list( $include ) );
-        }
-
-        if ( ! empty( $inclusions ) ) {
+
             $this->sql_clauses['where']['inclusions'] = 't.term_id IN ( ' . $inclusions . ' )';
         }
@@ -816 +813 @@
 
         if ( empty( $terms ) ) {
+            $this->terms = array();
+
             if ( $args['cache_results'] ) {
-                wp_cache_set_salted( $cache_key, array(), 'term-queries', $last_changed );
-            }
-            return array();
+                wp_cache_set_salted( $cache_key, $this->terms, 'term-queries', $last_changed );
+            }
+
+            return $this->terms;
         }
 

trunk/tests/phpunit/tests/post/query.php

@@ -780 +780 @@
 
     /**
+     * @ticket 47719
+     */
+    public function test_post__in_should_return_no_posts_when_0() {
+        self::factory()->post->create_many( 4 );
+
+        $query = new WP_Query(
+            array(
+                'post_type' => 'post',
+                'post__in'  => array( 0 ),
+            )
+        );
+
+        $this->assertSame( array(), $query->posts );
+        $this->assertSame( 0, $query->found_posts );
+    }
+
+    /**
      * @ticket 57296
      * @covers WP_Query::get_posts

trunk/tests/phpunit/tests/term/query.php

@@ -1050 +1050 @@
 
         $this->assertContains( $t1, $q->terms );
+    }
+
+    /**
+     * @ticket 47719
+     */
+    public function test_include_should_return_no_terms_when_0() {
+        register_taxonomy( 'wptests_tax', 'post' );
+
+        self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
+
+        $query = new WP_Term_Query(
+            array(
+                'taxonomy' => 'wptests_tax',
+                'include'  => array( 0 ),
+            )
+        );
+
+        $expected = array();
+        $this->assertSame( $expected, $query->terms );
+        $this->assertSame( $expected, $query->get_terms() );
     }
 

trunk/tests/phpunit/tests/user/query.php

@@ -1739 +1739 @@
         // Make sure manually setting total_users doesn't get overwritten.
         $this->assertSame( 1, $q->total_users );
+    }
+
+    /**
+     * @ticket 47719
+     */
+    public function test_include_should_return_no_users_when_0() {
+        $query = new WP_User_Query(
+            array(
+                'role'    => '',
+                'include' => array( 0 ),
+            )
+        );
+
+        $this->assertSame( array(), $query->get_results() );
     }