Changeset 61048 for trunk/tests/phpunit/tests/term/query.php

Timestamp:

10/22/2025 04:28:33 PM (12 months ago)

Author:

johnjamesjacoby

Message:

Query: Prevent querying for all terms in WP_Term_Query when include is set to [0].

This change brings the include parameter of WP_Term_Query up-to-speed with the include and __in parameters of other _Query classes, so that sending a value of [0] will not unintentionally perform an unbound query that returns all Terms.

It also introduces 3 new unit tests (for the Post, Term, and User query classes) to compare this behavior between them and ensure they remain consistent going forward.

Props audrasjb, hareesh-pillai, hellofromTonya, johnjamesjacoby, mukesh27.

Fixes #47719.

File:

• trunk/tests/phpunit/tests/term/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/query.php

@@ -1050 +1050 @@
 
                 $this->assertContains( $t1, $q->terms );
+        }
+
+        /**
+         * @ticket 47719
+         */
+        public function test_include_should_return_no_terms_when_0() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
+
+                $query = new WP_Term_Query(
+                        array(
+                                'taxonomy' => 'wptests_tax',
+                                'include'  => array( 0 ),
+                        )
+                );
+
+                $expected = array();
+                $this->assertSame( $expected, $query->terms );
+                $this->assertSame( $expected, $query->get_terms() );
         }