Changeset 61053

Timestamp:

10/22/2025 11:23:50 PM (3 weeks ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions consistently in wp-includes/formatting.php.

While Yoda conditions are mostly relevant for variables and not required if neither side is a variable, this commit aims to make the order more consistent throughout the file.

Follow-up to [1636], [4990], [6974], [10322], [10769], [11048], [42770], [47219], [56325].

Props subrataemfluence, sabernhardt, ishikaatxecurify, callumbw95, peterwilsoncc, SergeyBiryukov.
Fixes #46846.

File:

• trunk/src/wp-includes/formatting.php (modified) (9 diffs)

trunk/src/wp-includes/formatting.php

@@ -447 +447 @@
     $pre_tags = array();
 
-    if ( trim( $text ) === '' ) {
+    if ( '' === trim( $text ) ) {
         return '';
     }
@@ -1182 +1182 @@
             $unicode_length += $encoded_char_length;
         } else {
-            if ( count( $values ) === 0 ) {
+            if ( 0 === count( $values ) ) {
                 if ( $value < 224 ) {
                     $num_octets = 2;
@@ -2559 +2559 @@
  */
 function balanceTags( $text, $force = false ) {  // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
-    if ( $force || (int) get_option( 'use_balanceTags' ) === 1 ) {
+    if ( $force || 1 === (int) get_option( 'use_balanceTags' ) ) {
         return force_balance_tags( $text );
     } else {
@@ -3000 +3000 @@
     // Removed trailing [.,;:)] from URL.
     $last_char = substr( $dest, -1 );
-    if ( in_array( $last_char, array( '.', ',', ';', ':', ')' ), true ) === true ) {
+    if ( in_array( $last_char, array( '.', ',', ';', ':', ')' ), true ) ) {
         $ret  = $last_char;
         $dest = substr( $dest, 0, strlen( $dest ) - 1 );
@@ -3327 +3327 @@
 
     // Don't run (more expensive) regex if no links with targets.
-    if ( stripos( $text, 'target' ) === false || stripos( $text, '<a ' ) === false || is_serialized( $text ) ) {
+    if ( false === stripos( $text, 'target' ) || false === stripos( $text, '<a ' ) || is_serialized( $text ) ) {
         return $text;
     }
@@ -3447 +3447 @@
     global $wpsmiliestrans;
 
-    if ( count( $matches ) === 0 ) {
+    if ( 0 === count( $matches ) ) {
         return '';
     }
@@ -3573 +3573 @@
 
     // Test for an @ character after the first position.
-    if ( strpos( $email, '@', 1 ) === false ) {
+    if ( false === strpos( $email, '@', 1 ) ) {
         /** This filter is documented in wp-includes/formatting.php */
         return apply_filters( 'is_email', false, $email, 'email_no_at' );
@@ -3787 +3787 @@
 
     // Test for an @ character after the first position.
-    if ( strpos( $email, '@', 1 ) === false ) {
+    if ( false === strpos( $email, '@', 1 ) ) {
         /** This filter is documented in wp-includes/formatting.php */
         return apply_filters( 'sanitize_email', '', $email, 'email_no_at' );
@@ -5363 +5363 @@
     $args   = (array) $args;
     $result = array_shift( $args );
-    if ( count( $args ) === 1 ) {
+    if ( 1 === count( $args ) ) {
         $result .= $l['between_only_two'] . array_shift( $args );
     }