Changeset 61097

Timestamp:

10/30/2025 06:35:30 PM (7 days ago)

Author:

joedolson

Message:

Twenty Ten: Fix post navigation to respect sort order.

Change the labels on post navigation links when the sort order is changed so the labels accurately reflect the target entries.

Previously, if the sort order was reversed, 'Older' or 'Previous' links would navigate to newer entries and 'Newer' or 'Next' links would navigate to older entries.

Props jikamens, dancameron, obenland, denis-de-bernardy, nacin, chriscct7, shreya0shrivastava, sirlouen, sabernhardt, shailu25, westonruter, joedolson.
Fixes #10219.

File:

• trunk/src/wp-content/themes/twentyten/loop.php (modified) (2 diffs)

trunk/src/wp-content/themes/twentyten/loop.php

@@ -21 +21 @@
 
 <?php // Display navigation to next/previous pages when applicable. ?>
-<?php if ( $wp_query->max_num_pages > 1 ) : ?>
+<?php
+if ( $wp_query->max_num_pages > 1 ) :
+    $is_desc = ( 'DESC' === get_query_var( 'order', 'DESC' ) );
+
+    $new_posts_text = __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentyten' );
+    $old_posts_text = __( '<span class="meta-nav">&larr;</span> Older posts', 'twentyten' );
+
+    $prev_link = $is_desc ? get_next_posts_link( $old_posts_text ) : get_previous_posts_link( $old_posts_text );
+    $next_link = $is_desc ? get_previous_posts_link( $new_posts_text ) : get_next_posts_link( $new_posts_text );
+    ?>
     <div id="nav-above" class="navigation">
-        <div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'twentyten' ) ); ?></div>
-        <div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentyten' ) ); ?></div>
+    <?php if ( $prev_link ) : ?>
+        <div class="nav-previous"><?php echo $prev_link; ?></div>
+    <?php endif; ?>
+
+    <?php if ( $next_link ) : ?>
+        <div class="nav-next"><?php echo $next_link; ?></div>
+    <?php endif; ?>
     </div><!-- #nav-above -->
 <?php endif; ?>
@@ -206 +220 @@
 <?php if ( $wp_query->max_num_pages > 1 ) : ?>
                 <div id="nav-below" class="navigation">
-                    <div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'twentyten' ) ); ?></div>
-                    <div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentyten' ) ); ?></div>
+                <?php if ( $prev_link ) : ?>
+                    <div class="nav-previous"><?php echo $prev_link; ?></div>
+                <?php endif; ?>
+
+                <?php if ( $next_link ) : ?>
+                    <div class="nav-next"><?php echo $next_link; ?></div>
+                <?php endif; ?>
                 </div><!-- #nav-below -->
 <?php endif; ?>