Make WordPress Core


Ignore:
Timestamp:
10/31/2025 06:55:47 PM (6 months ago)
Author:
adamsilverstein
Message:

Editor: Notes should not appear in the context of comments.

Prevent notes from inadvertently showing up in the context of comments - including on the Dashboard recent comments widget and the “Mine” count on the Comments page. Notes are stored as a custom ‘note’ comment type and this change ensures the note type is only returned when explicitly requested, or when ‘all’ types are requested.

The query for note children is modified to return all child notes. This fixes an issue where children were no longer being returned for the ‘note’ type.

Also fixes https://github.com/WordPress/gutenberg/issues/72548.

Props adamsilverstein, timothyblynjacobs, shailu25, peterwilsoncc, westonruter, mamaduka, kadamwhite.
Fixes #64145.
Fixes #64152.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

    r61002 r61105  
    12551255                'count'   => true,
    12561256                'orderby' => 'none',
     1257                'type'    => 'all',
    12571258            )
    12581259        );
     
    12611262            $args = array(
    12621263                'parent' => $comment->comment_ID,
     1264            );
     1265
     1266            $rest_url = add_query_arg( $args, rest_url( $this->namespace . '/' . $this->rest_base ) );
     1267
     1268            $links['children'] = array(
     1269                'href'       => $rest_url,
     1270                'embeddable' => true,
     1271            );
     1272        }
     1273
     1274        // Embedding children for notes requires `type` and `status` inheritance.
     1275        if ( isset( $links['children'] ) && 'note' === $comment->comment_type ) {
     1276            $args = array(
     1277                'parent' => $comment->comment_ID,
     1278                'type'   => $comment->comment_type,
     1279                'status' => 'all',
    12631280            );
    12641281
Note: See TracChangeset for help on using the changeset viewer.