Changeset 61105 for trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Timestamp:

10/31/2025 06:55:47 PM (4 months ago)

Author:

adamsilverstein

Message:

Editor: Notes should not appear in the context of comments.

Prevent notes from inadvertently showing up in the context of comments - including on the Dashboard recent comments widget and the “Mine” count on the Comments page. Notes are stored as a custom ‘note’ comment type and this change ensures the note type is only returned when explicitly requested, or when ‘all’ types are requested.

The query for note children is modified to return all child notes. This fixes an issue where children were no longer being returned for the ‘note’ type.

Also fixes ​https://github.com/WordPress/gutenberg/issues/72548.

Props adamsilverstein, timothyblynjacobs, shailu25, peterwilsoncc, westonruter, mamaduka, kadamwhite.
Fixes #64145.
Fixes #64152.

File:

• trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -4077 +4077 @@
         );
     }
+
+    /**
+     * Test children link for note comment type. Based on test_get_comment_with_children_link.
+     *
+     * @ticket 64152
+     */
+    public function test_get_note_with_children_link() {
+        $parent_comment_id = self::factory()->comment->create(
+            array(
+                'comment_approved' => 1,
+                'comment_post_ID'  => self::$post_id,
+                'user_id'          => self::$admin_id,
+                'comment_type'     => 'note',
+                'comment_content'  => 'Parent note comment',
+            )
+        );
+
+        self::factory()->comment->create(
+            array(
+                'comment_approved' => 1,
+                'comment_parent'   => $parent_comment_id,
+                'comment_post_ID'  => self::$post_id,
+                'user_id'          => self::$admin_id,
+                'comment_type'     => 'note',
+                'comment_content'  => 'First child note comment',
+            )
+        );
+
+        wp_set_current_user( self::$admin_id );
+        $request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/comments/%s', $parent_comment_id ) );
+        $request->set_param( 'type', 'note' );
+        $request->set_param( 'context', 'edit' );
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertSame( 200, $response->get_status() );
+
+        $this->assertArrayHasKey( 'children', $response->get_links() );
+
+        $request = new WP_REST_Request( 'GET', '/wp/v2/comments' );
+        $request->set_param( 'post', self::$post_id );
+        $request->set_param( 'type', 'note' );
+        $request->set_param( 'context', 'edit' );
+        $request->set_param( 'parent', 0 );
+
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertSame( 200, $response->get_status() );
+
+        $data = $response->get_data();
+
+        $this->assertArrayHasKey( '_links', $data[0] );
+        $this->assertArrayHasKey( 'children', $data[0]['_links'] );
+
+        $children = $data[0]['_links']['children'];
+
+        // Verify the href attribute contains the expected status and type parameters.
+        $this->assertStringContainsString( 'status=all', $children[0]['href'] );
+        $this->assertStringContainsString( 'type=note', $children[0]['href'] );
+    }
 }