Changeset 61123 for trunk/src/wp-admin/includes/class-wp-site-health.php

Timestamp:

11/04/2025 08:48:41 AM (9 months ago)

Author:

westonruter

Message:

Site Health: Improve messaging for PHP version status.

Previously, the status could be misleading, especially if the check against the WordPress.org API failed. The initial status message is now more neutral, and a dedicated check has been added to handle cases where the API is unreachable.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/7350

Follow-up to [58832].

Props pbearne, joemcgill, mukesh27, peterwilsoncc, swb1192, krupajnanda, psykro, SergeyBiryukov, swissspidy, imranhasanraaz, amin7, flixos90, vgnavada, audrasjb, adamsilverstein, Presskopp, westonruter.
Fixes #61623.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -729 +729 @@
                 $result = array(
                         'label'       => sprintf(
-                                /* translators: %s: The recommended PHP version. */
-                                __( 'Your site is running a recommended version of PHP (%s)' ),
+                                /* translators: %s: The server PHP version. */
+                                __( 'Your site is running PHP %s' ),
                                 PHP_VERSION
                         ),
@@ -740 +740 @@
                         'description' => sprintf(
                                 '<p>%s</p>',
-                                sprintf(
-                                        /* translators: %s: The minimum recommended PHP version. */
-                                        __( 'PHP is one of the programming languages used to build WordPress. Newer versions of PHP receive regular security updates and may increase your site&#8217;s performance. The minimum recommended version of PHP is %s.' ),
-                                        $response ? $response['recommended_version'] : ''
-                                )
+                                __( 'PHP is one of the programming languages used to build WordPress. Newer versions of PHP receive regular security updates and may increase your site&#8217;s performance.' )
                         ),
                         'actions'     => sprintf(
@@ -756 +752 @@
                 );
 
+                if ( ! $response ) {
+                        $result['label'] = sprintf(
+                                /* translators: %s: The server PHP version. */
+                                __( 'Unable to determine the status of the current PHP version (%s)' ),
+                                PHP_VERSION
+                        );
+                        $result['status']      = 'recommended';
+                        $result['description'] = '<p><em>' . sprintf(
+                                /* translators: %s is the URL to the Serve Happy docs page. */
+                                __( 'Unable to access the WordPress.org API for <a href="%s">Serve Happy</a>.' ),
+                                'https://codex.wordpress.org/WordPress.org_API#Serve_Happy'
+                        ) . '</em></p>' . $result['description'];
+                        return $result;
+                }
+
+                $result['description'] .= '<p>' . sprintf(
+                        /* translators: %s: The minimum recommended PHP version. */
+                        __( 'The minimum recommended version of PHP is %s.' ),
+                        $response['recommended_version']
+                ) . '</p>';
+
                 // PHP is up to date.
-                if ( ! $response || version_compare( PHP_VERSION, $response['recommended_version'], '>=' ) ) {
+                if ( version_compare( PHP_VERSION, $response['recommended_version'], '>=' ) ) {
+                        $result['label'] = sprintf(
+                                /* translators: %s: The server PHP version. */
+                                __( 'Your site is running a recommended version of PHP (%s)' ),
+                                PHP_VERSION
+                        );
+                        $result['status'] = 'good';
+
                         return $result;
                 }