Changeset 61126

Timestamp:

11/04/2025 01:59:06 PM (3 months ago)

Author:

davidbaumwald

Message:

Command Palette: Use HTML_Tag_Processor to get the menu label when enqueueing assets, not regex.

HTML_Tag_Processor is more better.

Follow-up to [61022].

Props dmsnell, cbravobernal.
Fixes #64196.

File:

• trunk/src/wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/wp-includes/script-loader.php

@@ -3443 +3443 @@
 
             // Remove all HTML tags and their contents.
-            $menu_label = $menu_item[0];
-            while ( preg_match( '/<[^>]*>/', $menu_label ) ) {
-                $menu_label = preg_replace( '/<[^>]*>.*?<\/[^>]*>|<[^>]*\/>|<[^>]*>/s', '', $menu_label );
+            $processor = new WP_HTML_Tag_Processor( $menu_item[0] );
+            while ( $processor->next_token() ) {
+                if ( '#text' === $processor->get_token_name() ) {
+                    $menu_label .= $processor->get_modifiable_text();
+                }
             }
             $menu_label = trim( $menu_label );
@@ -3472 +3474 @@
 
                     // Remove all HTML tags and their contents.
-                    $submenu_label = $submenu_item[0];
-                    while ( preg_match( '/<[^>]*>/', $submenu_label ) ) {
-                        $submenu_label = preg_replace( '/<[^>]*>.*?<\/[^>]*>|<[^>]*\/>|<[^>]*>/s', '', $submenu_label );
+                    $processor     = new WP_HTML_Tag_Processor( $submenu_item[0] );
+                    $submenu_label = '';
+                    while ( $processor->next_token() ) {
+                        if ( '#text' === $processor->get_token_name() ) {
+                            $submenu_label .= $processor->get_modifiable_text();
+                        }
                     }
                     $submenu_label = trim( $submenu_label );