Changeset 61130 for trunk/tests/phpunit/tests/rest-api/wpRestAbilitiesV1ListController.php

Timestamp:

11/04/2025 04:32:45 PM (9 months ago)

Author:

jorgefilipecosta

Message:

Abilities API: Use stricter doing_action check when registering.

Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues.

Developed in #10452.

Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams.
See #64098.

File:

• trunk/tests/phpunit/tests/rest-api/wpRestAbilitiesV1ListController.php (modified) (9 diffs)

trunk/tests/phpunit/tests/rest-api/wpRestAbilitiesV1ListController.php

@@ -38 +38 @@
                 );
 
-                // Fire the init hook to allow test ability categories registration.
-                do_action( 'wp_abilities_api_categories_init' );
                 self::register_test_categories();
         }
@@ -68 +66 @@
                 do_action( 'rest_api_init' );
 
-                // Initialize Abilities API.
-                do_action( 'wp_abilities_api_init' );
                 $this->register_test_abilities();
 
@@ -100 +96 @@
          */
         public static function register_test_categories(): void {
+                // Simulates the init hook to allow test ability categories registration.
+                global $wp_current_filter;
+                $wp_current_filter[] = 'wp_abilities_api_categories_init';
+
                 wp_register_ability_category(
                         'math',
@@ -123 +123 @@
                         )
                 );
+
+                array_pop( $wp_current_filter );
+        }
+
+        /**
+         * Helper to register a test ability.
+         *
+         * @param string $name Ability name.
+         * @param array  $args Ability arguments.
+         */
+        private function register_test_ability( string $name, array $args ): void {
+                // Simulates the init hook to allow test abilities registration.
+                global $wp_current_filter;
+                $wp_current_filter[] = 'wp_abilities_api_init';
+
+                wp_register_ability( $name, $args );
+
+                array_pop( $wp_current_filter );
         }
 
@@ -130 +148 @@
         private function register_test_abilities(): void {
                 // Register a regular ability.
-                wp_register_ability(
+                $this->register_test_ability(
                         'test/calculator',
                         array(
@@ -174 +192 @@
 
                 // Register a read-only ability.
-                wp_register_ability(
+                $this->register_test_ability(
                         'test/system-info',
                         array(
@@ -221 +239 @@
 
                 // Ability that does not show in REST.
-                wp_register_ability(
+                $this->register_test_ability(
                         'test/not-show-in-rest',
                         array(
@@ -236 +254 @@
                 // Register multiple abilities for pagination testing
                 for ( $i = 1; $i <= 60; $i++ ) {
-                        wp_register_ability(
+                        $this->register_test_ability(
                                 "test/ability-{$i}",
                                 array(
@@ -590 +608 @@
         public function test_ability_name_with_valid_special_characters(): void {
                 // Register ability with hyphen (valid).
-                wp_register_ability(
+                $this->register_test_ability(
                         'test-hyphen/ability',
                         array(