Changeset 61142

Timestamp:

11/05/2025 04:21:28 PM (9 months ago)

Author:

cbravobernal

Message:

Command Palette: Revert Use HTLM_Tag_Processor to get the menu label when enqueueing assets.

Reverts [61126] and [61127], which introduced a bug where the command palette is not stripping numbers. HTML_Tag_Processor cannot replace the REGEX yet.

Unprops cbravobernal.

Follow-up to [61126], [61127].

Props wildworks, tusharaddweb.
See #64196.

File:

• trunk/src/wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/wp-includes/script-loader.php

@@ -3443 +3443 @@
 
                         // Remove all HTML tags and their contents.
-                        $processor  = new WP_HTML_Tag_Processor( $menu_item[0] );
-                        $menu_label = '';
-                        while ( $processor->next_token() ) {
-                                if ( '#text' === $processor->get_token_name() ) {
-                                        $menu_label .= $processor->get_modifiable_text();
-                                }
+                        $menu_label = $menu_item[0];
+                        while ( preg_match( '/<[^>]*>/', $menu_label ) ) {
+                                $menu_label = preg_replace( '/<[^>]*>.*?<\/[^>]*>|<[^>]*\/>|<[^>]*>/s', '', $menu_label );
                         }
                         $menu_label = trim( $menu_label );
@@ -3475 +3472 @@
 
                                         // Remove all HTML tags and their contents.
-                                        $processor     = new WP_HTML_Tag_Processor( $submenu_item[0] );
-                                        $submenu_label = '';
-                                        while ( $processor->next_token() ) {
-                                                if ( '#text' === $processor->get_token_name() ) {
-                                                        $submenu_label .= $processor->get_modifiable_text();
-                                                }
+                                        $submenu_label = $submenu_item[0];
+                                        while ( preg_match( '/<[^>]*>/', $submenu_label ) ) {
+                                                $submenu_label = preg_replace( '/<[^>]*>.*?<\/[^>]*>|<[^>]*\/>|<[^>]*>/s', '', $submenu_label );
                                         }
                                         $submenu_label = trim( $submenu_label );