Changeset 61171 for trunk/src/wp-includes/post.php

Timestamp:

11/06/2025 10:22:52 PM (11 months ago)

Author:

westonruter

Message:

Tests: Fix unit test failure in PHP 8.5 due using null as an array offset.

This adds is_string() type checks for the $post_status arg passed to both get_post_status_object() and is_post_status_viewable(). This was triggered by Tests_Post_IsPostStatusViewable::test_built_in_and_unregistered_status_types() for the null data set.

Follow-up to [61170].

See #63167, #63061.

File:

• trunk/src/wp-includes/post.php (modified) (2 diffs)

trunk/src/wp-includes/post.php

@@ -1513 +1513 @@
         global $wp_post_statuses;
 
-        if ( empty( $wp_post_statuses[ $post_status ] ) ) {
+        if ( ! is_string( $post_status ) || empty( $wp_post_statuses[ $post_status ] ) ) {
                 return null;
         }
@@ -2456 +2456 @@
 function is_post_status_viewable( $post_status ) {
         if ( is_scalar( $post_status ) ) {
+                if ( ! is_string( $post_status ) ) {
+                        return false;
+                }
+
                 $post_status = get_post_status_object( $post_status );