Changeset 61185

Timestamp:

11/07/2025 11:38:10 PM (9 months ago)

Author:

SergeyBiryukov

Message:

Tests: Improve unit tests for feed_links_extra().

Includes:

• Converting data provider methods to static for a slight performance improvement.
• Correcting annotations for consistency.

Follow-up to [53033], [53125], [54161].

Props mukesh27, SergeyBiryukov.
See #63167.

File:

• trunk/tests/phpunit/tests/general/feedLinksExtra.php (modified) (7 diffs)

trunk/tests/phpunit/tests/general/feedLinksExtra.php

@@ -2 +2 @@
 /**
  * Test feed_links_extra().
- *
- * @ticket 54713
  *
  * @group general
@@ -165 +163 @@
 
         /**
+         * @ticket 54713
+         *
          * @dataProvider data_feed_links_extra
-         * @ticket 54713
-         *
-         * @param string $title     The expected title.
-         * @param string $type      The name of the test class property containing the object ID.
-         * @param array  $args {
+         *
+         * @param string $title The expected title.
+         * @param string $type  The name of the test class property containing the object ID.
+         * @param array  $args  {
          *        Optional arguments. Default empty.
          *
@@ -211 +210 @@
          * @return array
          */
-        public function data_feed_links_extra() {
+        public static function data_feed_links_extra() {
                 return array(
                         'a post with a comment'                        => array(
@@ -400 +399 @@
         /**
          * Helper function to get the permalink based on type.
-         *
-         * @ticket 54713
          *
          * @param string $type The name of the test class property containing the object ID.
@@ -523 +520 @@
 
         /**
+         * @ticket 54703
+         *
          * @dataProvider data_feed_links_extra_should_output_nothing_when_post_comments_feed_link_is_falsy
-         *
-         * @ticket 54703
          *
          * @param string $callback The callback to use for the 'post_comments_feed_link' filter.
@@ -582 +579 @@
 
         /**
+         * @ticket 55904
+         *
          * @dataProvider data_feed_links_extra_should_output_nothing_when_filters_return_false
-         *
-         * @ticket 55904
          *
          * @param string $type   The name of the test class property containing the object ID.
@@ -603 +600 @@
          * @return array
          */
-        public function data_feed_links_extra_should_output_nothing_when_filters_return_false() {
+        public static function data_feed_links_extra_should_output_nothing_when_filters_return_false() {
                 return array(
                         'a post with a comment' => array(