Changeset 61210 for trunk/src/wp-includes/class-wp-user.php

Timestamp:

11/11/2025 12:51:01 PM (3 months ago)

Author:

SergeyBiryukov

Message:

Users: Initialize the WP_User::$roles property as a sequential array.

Previously, if any roles were filtered out via array_filter() when assigning the WP_User::$roles property in WP_User::get_role_caps(), the resulting array could contain non-sequential numeric keys, which would then cause it to be treated as an object when JSON-encoded, e.g. in wp_localize_script(), instead of a proper array, breaking client-side expectations.

This commit ensures that the WP_User::$roles property is always treated as an array.

Follow-up to [2703], [2793], [22118].

Props haruncpi, peterwilsoncc, SirLouen, getsyash, wildworks, johnjamesjacoby, SergeyBiryukov.
Fixes #63427.

File:

• trunk/src/wp-includes/class-wp-user.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-user.php

@@ -516 +516 @@
         $wp_roles = wp_roles();
 
-        // Filter out caps that are not role names and assign to $this->roles.
+        // Select caps that are role names and assign to $this->roles.
         if ( is_array( $this->caps ) ) {
-            $this->roles = array_filter( array_keys( $this->caps ), array( $wp_roles, 'is_role' ) );
+            $this->roles = array();
+
+            foreach ( $this->caps as $key => $value ) {
+                if ( $wp_roles->is_role( $key ) ) {
+                    $this->roles[] = $key;
+                }
+            }
         }