Changeset 61223 for trunk/src/wp-includes/class-wp-scripts.php

Timestamp:

11/12/2025 11:34:56 AM (11 months ago)

Author:

jonsurrell

Message:

Script Loader: Omit sourceURL from translation data when not printed.

The data returned from WP_Scripts::print_translations() when $display is false may be used in unpredictable ways that are incompatible with sourceURL comments. Omit the sourceURL comment in this case.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10505.

Follow-up to [60719].

Props jonsurrell, ralucastn, westonruter, peterwilsoncc.
See #63887.

File:

• trunk/src/wp-includes/class-wp-scripts.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-scripts.php

@@ -351 +351 @@
                 $translations = $this->print_translations( $handle, false );
                 if ( $translations ) {
-                        $translations = wp_get_inline_script_tag( $translations, array( 'id' => "{$handle}-js-translations" ) );
+                        /*
+                         * The sourceURL comment is not included by WP_Scripts::print_translations()
+                         * when `$display` is `false` to prevent issues where the script tag contents are used
+                         * by extenders for other purposes, for example concatenated with other script content.
+                         *
+                         * Include the sourceURL comment here as it would be when printed directly.
+                         */
+                        $source_url    = rawurlencode( "{$handle}-js-translations" );
+                        $translations .= "\n//# sourceURL={$source_url}";
+                        $translations  = wp_get_inline_script_tag( $translations, array( 'id' => "{$handle}-js-translations" ) );
                 }
 
@@ -723 +732 @@
                 }
 
-                $source_url = rawurlencode( "{$handle}-js-translations" );
-
                 $output = <<<JS
 ( function( domain, translations ) {
@@ -731 +738 @@
         wp.i18n.setLocaleData( localeData, domain );
 } )( "{$domain}", {$json_translations} );
-//# sourceURL={$source_url}
 JS;
 
                 if ( $display ) {
+                        $source_url = rawurlencode( "{$handle}-js-translations" );
+                        $output    .= "\n//# sourceURL={$source_url}";
                         wp_print_inline_script_tag( $output, array( 'id' => "{$handle}-js-translations" ) );
                 }