Changeset 61247

Timestamp:

11/14/2025 10:11:11 PM (3 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Cast base_convert() to an integer before arithmetic operations.

Follow-up to [35477], [53104], [56101].

Props justlevine.
See #64238.

Location:

trunk/src

Files:

• wp-admin/includes/plugin.php (modified) (1 diff)
• wp-includes/class-wp-duotone.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin.php

@@ -1428 +1428 @@
         $menu[] = $new_menu;
     } elseif ( isset( $menu[ (string) $position ] ) ) {
-        $collision_avoider = base_convert( substr( md5( $menu_slug . $menu_title ), -4 ), 16, 10 ) * 0.00001;
+        $collision_avoider = (int) base_convert( substr( md5( $menu_slug . $menu_title ), -4 ), 16, 10 ) * 0.00001;
         $position          = (string) ( $position + $collision_avoider );
         $menu[ $position ] = $new_menu;

trunk/src/wp-includes/class-wp-duotone.php

@@ -247 +247 @@
                 'g' => (int) base_convert( $hex[1] . $hex[1], 16, 10 ),
                 'b' => (int) base_convert( $hex[2] . $hex[2], 16, 10 ),
-                'a' => 4 === strlen( $hex ) ? round( base_convert( $hex[3] . $hex[3], 16, 10 ) / 255, 2 ) : 1,
+                'a' => 4 === strlen( $hex ) ? round( (int) base_convert( $hex[3] . $hex[3], 16, 10 ) / 255, 2 ) : 1,
             );
         }