Changeset 61286

Timestamp:

11/24/2025 05:41:12 PM (8 months ago)

Author:

desrosj

Message:

Build/Test Tools: Introduce post-branching Grunt task.

In [59673], a Grunt subtask was introduced to convert workflow file references in GitHub Action workflows from local ones to remote ones that target the trunk branch.

The workflow-references-local-to-remote Grunt task should be run after creating a new numbered branch to take advantage of the work started in [58165].

This commit introduces a new target for the clean Grunt task: workflows. Running grunt clean:workflows will delete all workflow files that are not intended to exist outside of trunk.

Another Grunt task (post-branching) has also been added as a way to group all tasks taht should run within a newly created branch. For now, this contains clean:workflows and replace:workflow-references-local-to-remote. But more can be added in the future as more aspects of the branching process are automated.

Props johnbillion.
See #64227.

File:

• trunk/Gruntfile.js (modified) (3 diffs)

trunk/Gruntfile.js

@@ -60 +60 @@
                 ],
 
+                // All workflow files that should be deleted from non-default branches.
+                workflowFiles = [
+                        // Reusable workflows should be called from `trunk` within branches.
+                        '.github/workflows/reusable-*.yml',
+                        // These workflows are only intended to run from `trunk`.
+                        '.github/workflows/commit-built-file-changes.yml',
+                        '.github/workflows/failed-workflow.yml',
+                        '.github/workflows/install-testing.yml',
+                        '.github/workflows/test-and-zip-default-themes.yml',
+                        '.github/workflows/install-testing.yml',
+                        '.github/workflows/slack-notifications.yml',
+                        '.github/workflows/test-coverage.yml',
+                        '.github/workflows/test-old-branches.yml',
+                        '.github/workflows/upgrade-testing.yml'
+                ],
+
                 // Prepend `dir` to `file`, and keep `!` in place.
                 setFilePath = function( dir, file ) {
@@ -217 +233 @@
                                 src: []
                         },
-                        qunit: ['tests/qunit/compiled.html']
+                        qunit: ['tests/qunit/compiled.html'],
+
+                        // This is only meant to run within a numbered branch after branching has occurred.
+                        workflows: {
+                                filter: function() {
+                                        var allowedTasks = [ 'post-branching', 'clean:workflows' ];
+                                        return allowedTasks.some( function( task ) {
+                                                return grunt.cli.tasks.indexOf( task ) !== -1;
+                                        } );
+                                },
+                                src: workflowFiles
+                        },
                 },
                 file_append: {
@@ -1709 +1736 @@
         ]);
 
+        grunt.registerTask( 'post-branching', [
+                'clean:workflows',
+                'replace:workflow-references-local-to-remote'
+        ]);
+
         /**
          * Build verification tasks.