Changeset 61311

Timestamp:

11/26/2025 09:50:02 PM (11 months ago)

Author:

SergeyBiryukov

Message:

Filesystem API: Check for the correct result in some WP_Filesystem_FTPext methods.

This avoids a PHP warning when ::dirlist() returns false under certain conditions:

Warning: Trying to access array offset on value of type bool in wp-admin/includes/class-wp-filesystem-ftpsockets.php on line 326

Follow-up to [6779], [30678], [45226].

Props apermo, malt3, SergeyBiryukov.
Fixes #63474.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-filesystem-ftpext.php (modified) (3 diffs)
• class-wp-filesystem-ftpsockets.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-filesystem-ftpext.php

@@ -300 +300 @@
                 $dir = $this->dirlist( $file );
 
-                return $dir[ $file ]['owner'];
+                return $dir[ $file ]['owner'] ?? '';
         }
 
@@ -314 +314 @@
                 $dir = $this->dirlist( $file );
 
-                return $dir[ $file ]['permsn'];
+                return $dir[ $file ]['permsn'] ?? '';
         }
 
@@ -328 +328 @@
                 $dir = $this->dirlist( $file );
 
-                return $dir[ $file ]['group'];
+                return $dir[ $file ]['group'] ?? '';
         }
 

trunk/src/wp-admin/includes/class-wp-filesystem-ftpsockets.php

@@ -310 +310 @@
                 $dir = $this->dirlist( $file );
 
-                return $dir[ $file ]['owner'];
+                return $dir[ $file ]['owner'] ?? '';
         }
 
@@ -324 +324 @@
                 $dir = $this->dirlist( $file );
 
-                return $dir[ $file ]['permsn'];
+                return $dir[ $file ]['permsn'] ?? '';
         }
 
@@ -338 +338 @@
                 $dir = $this->dirlist( $file );
 
-                return $dir[ $file ]['group'];
+                return $dir[ $file ]['group'] ?? '';
         }