Changeset 61335 for branches/6.9/tests/phpunit/tests/rest-api/rest-settings-controller.php

Timestamp:

12/01/2025 03:01:27 PM (2 months ago)

Author:

SergeyBiryukov

Message:

Options, Meta APIs: Revert additional request validity handling that was added to the /wp/v2/settings REST API route. This change needs more work to account for URL query parameters used in place of body data.

This reverts [60357] and [60301].

Reviewed by johnbillion, SergeyBiryukov.
Merges [61324] to the 6.9 branch.

See #41604.

Location:

branches/6.9

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/rest-api/rest-settings-controller.php (modified) (2 diffs)

branches/6.9/tests/phpunit/tests/rest-api/rest-settings-controller.php

@@ -386 +386 @@
 
     /**
-     * Settings can't be created
+     * @doesNotPerformAssertions
      */
     public function test_create_item() {
-        wp_set_current_user( self::$administrator );
-
-        $request = new WP_REST_Request( 'POST', '/wp/v2/settings' );
-        $request->set_param( 'new_setting', 'New value' );
-        $response = rest_get_server()->dispatch( $request );
-
-        $this->assertSame( 400, $response->get_status() );
-    }
-
-    /**
-     * @ticket 41604
-     */
+        // Controller does not implement create_item().
+    }
+
     public function test_update_item() {
         wp_set_current_user( self::$administrator );
-
         $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
         $request->set_param( 'title', 'The new title!' );
@@ -412 +402 @@
         $this->assertSame( 'The new title!', $data['title'] );
         $this->assertSame( get_option( 'blogname' ), $data['title'] );
-    }
-
-    /**
-     * @ticket 41604
-     */
-    public function test_update_item_with_global_parameters_present() {
-        wp_set_current_user( self::$administrator );
-
-        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
-        $request->set_param( 'title', 'The new title!' );
-        $request->set_url_params( array( '_locale' => 'user' ) );
-        $response = rest_get_server()->dispatch( $request );
-        $data     = $response->get_data();
-
-        $this->assertSame( 200, $response->get_status() );
-        $this->assertSame( 'The new title!', $data['title'] );
-        $this->assertSame( get_option( 'blogname' ), $data['title'] );
-    }
-
-    /**
-     * @ticket 41604
-     */
-    public function test_update_item_with_empty_body() {
-        wp_set_current_user( self::$administrator );
-
-        $request  = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
-        $response = rest_get_server()->dispatch( $request );
-        $data     = $response->get_data();
-
-        $this->assertSame( 400, $response->get_status() );
-    }
-
-    /**
-     * @ticket 41604
-     */
-    public function test_update_nonexistent_item() {
-        wp_set_current_user( self::$administrator );
-
-        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
-        $request->set_param( 'i_do_no_exist', 'New value' );
-        $response = rest_get_server()->dispatch( $request );
-
-        $this->assertSame( 400, $response->get_status() );
-    }
-
-    /**
-     * @ticket 41604
-     */
-    public function test_update_partially_valid_items() {
-        wp_set_current_user( self::$administrator );
-
-        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
-        $request->set_param( 'title', 'The new title!' );
-        $request->set_param( 'i_do_no_exist', 'New value' );
-        $response = rest_get_server()->dispatch( $request );
-
-        $this->assertSame( 400, $response->get_status() );
     }