Changeset 61374 for trunk/tests/phpunit/tests/filesystem/unzipFilePclzip.php

Timestamp:

12/13/2025 08:10:50 PM (10 months ago)

Author:

SergeyBiryukov

Message:

Filesystem API: Pass correct $file value to pre_unzip_file and unzip_file filters.

This commit ensures that the original $file argument passed to the function is not unintentionally overwritten by the use of the same variable name in two foreach loops.

Follow-up to [56689].

Props sanchothefat, westonruter, mukesh27, SergeyBiryukov.
Fixes #64398.

File:

• trunk/tests/phpunit/tests/filesystem/unzipFilePclzip.php (modified) (4 diffs)

trunk/tests/phpunit/tests/filesystem/unzipFilePclzip.php

@@ -38 +38 @@
         public function test_should_apply_pre_unzip_file_filters() {
                 $filter = new MockAction();
-                add_filter( 'pre_unzip_file', array( $filter, 'filter' ) );
+                add_filter( 'pre_unzip_file', array( $filter, 'filter' ), 10, 2 );
 
                 // Prepare test environment.
@@ -54 +54 @@
                 $this->delete_folders( $unzip_destination );
 
-                $this->assertSame( 1, $filter->get_call_count() );
+                $this->assertSame( 1, $filter->get_call_count(), 'The filter should be called once.' );
+                $this->assertSame( self::$test_data_dir . 'archive.zip', $filter->get_args()[0][1], 'The $file parameter should be correct.' );
         }
 
@@ -64 +65 @@
         public function test_should_apply_unzip_file_filters() {
                 $filter = new MockAction();
-                add_filter( 'unzip_file', array( $filter, 'filter' ) );
+                add_filter( 'unzip_file', array( $filter, 'filter' ), 10, 2 );
 
                 // Prepare test environment.
@@ -80 +81 @@
                 $this->delete_folders( $unzip_destination );
 
-                $this->assertSame( 1, $filter->get_call_count() );
+                $this->assertSame( 1, $filter->get_call_count(), 'The filter should be called once.' );
+                $this->assertSame( self::$test_data_dir . 'archive.zip', $filter->get_args()[0][1], 'The $file parameter should be correct.' );
         }
 }