Changeset 61376

Timestamp:

12/14/2025 07:11:49 AM (10 months ago)

Author:

westonruter

Message:

Taxonomy: Avoid type error in wp_delete_object_term_relationships() when invalid taxonomy supplied.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10621

Props owolter, westonruter.
Fixes #64406.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (1 diff)
• tests/phpunit/tests/term/wpDeleteObjectTermRelationships.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -2000 +2000 @@
         foreach ( (array) $taxonomies as $taxonomy ) {
                 $term_ids = wp_get_object_terms( $object_id, $taxonomy, array( 'fields' => 'ids' ) );
+                if ( ! is_array( $term_ids ) ) {
+                        // Skip return value in the case of an error or the 'wp_get_object_terms' filter returning an invalid value.
+                        continue;
+                }
                 $term_ids = array_map( 'intval', $term_ids );
                 wp_remove_object_terms( $object_id, $term_ids, $taxonomy );

trunk/tests/phpunit/tests/term/wpDeleteObjectTermRelationships.php

@@ -54 +54 @@
                 $this->assertSameSets( array( $t2 ), $terms );
         }
+
+        /**
+         * @ticket 64406
+         */
+        public function test_delete_when_error() {
+                $taxonomy_name = 'wptests_tax';
+                register_taxonomy( $taxonomy_name, 'post' );
+                $term_id   = self::factory()->term->create( array( 'taxonomy' => $taxonomy_name ) );
+                $object_id = 567;
+                wp_set_object_terms( $object_id, array( $term_id ), $taxonomy_name );
+
+                // Confirm the setup.
+                $terms = wp_get_object_terms( $object_id, array( $taxonomy_name ), array( 'fields' => 'ids' ) );
+                $this->assertSame( array( $term_id ), $terms, 'Expected same object terms.' );
+
+                // Try wp_delete_object_term_relationships() when the taxonomy is invalid (no change expected).
+                wp_delete_object_term_relationships( $object_id, 'wptests_taxation' );
+                $terms = wp_get_object_terms( $object_id, array( $taxonomy_name ), array( 'fields' => 'ids' ) );
+                $this->assertSame( array( $term_id ), $terms, 'Expected the object terms to be unchanged.' );
+        }
 }