Changeset 61378

Timestamp:

12/14/2025 10:17:23 PM (2 months ago)

Author:

peterwilsoncc

Message:

REST API: Use valid host in unit tests for URL Details endpoint.

This ensures that the url parameter is not marked as invalid due to wp_http_validate_url() failing because of a gethostbyname() failure.

Follow-up to [51973].

Reviewed by peterwilsoncc.
Merges [61377] to the 6.9 branch.

Props westonruter, swissspidy.
See #54358.
Fixes #64412.

Location:

branches/6.9

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/rest-api/wpRestUrlDetailsController.php (modified) (3 diffs)

branches/6.9/tests/phpunit/tests/rest-api/wpRestUrlDetailsController.php

@@ -44 +44 @@
      * URL placeholder.
      *
+     * Even though the request is being intercepted with a mocked response, it is not fully bypassing the network. The
+     * REST API endpoint is validating the `url` parameter with `wp_http_validate_url()` which includes a call to
+     * `gethostbyname()`. So the domain used in the placeholder URL must be valid to ensure it passes a validity check.
+     *
      * @since 5.9.0
      *
      * @var string
      */
-    const URL_PLACEHOLDER = 'https://placeholder-site.com';
+    const URL_PLACEHOLDER = 'https://example.com';
 
     /**
@@ -130 +134 @@
             array(
                 'title'       => 'Example Website — - with encoded content.',
-                'icon'        => 'https://placeholder-site.com/favicon.ico?querystringaddedfortesting',
+                'icon'        => 'https://example.com/favicon.ico?querystringaddedfortesting',
                 'description' => 'Example description text here. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore.',
-                'image'       => 'https://placeholder-site.com/images/home/screen-themes.png?3',
+                'image'       => 'https://example.com/images/home/screen-themes.png?3',
             ),
             $data
@@ -445 +449 @@
         $this->assertSame( 418, $data['status'], 'Response "status" is not 418' );
 
-        $expected = 'Response for URL https://placeholder-site.com altered via rest_prepare_url_details filter';
+        $expected = 'Response for URL https://example.com altered via rest_prepare_url_details filter';
         $this->assertSame( $expected, $data['response'], 'Response "response" is not "' . $expected . '"' );
     }