Changeset 61379

Timestamp:

12/14/2025 10:28:52 PM (2 months ago)

Author:

westonruter

Message:

Heartbeat: Handle race condition in wp-auth-check where heartbeat-tick may fire before DOMContentLoaded.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10624

Follow-up to [23805], [50547].

Props westonruter, ArtZ91, siliconforks.
See #23295.
Fixes #64403.

File:

• trunk/src/js/_enqueues/lib/auth-check.js (modified) (2 diffs)

trunk/src/js/_enqueues/lib/auth-check.js

@@ -160 +160 @@
         });
     }).on( 'heartbeat-tick.wp-auth-check', function( e, data ) {
-        if ( 'wp-auth-check' in data ) {
+        if ( ! ( 'wp-auth-check' in data ) ) {
+            return;
+        }
+
+        var showOrHide = function () {
             if ( ! data['wp-auth-check'] && wrap.hasClass( 'hidden' ) && ! tempHidden ) {
                 show();
@@ -166 +170 @@
                 hide();
             }
+        };
+
+        // This is necessary due to a race condition where the heartbeat-tick event may fire before DOMContentLoaded.
+        if ( wrap ) {
+            showOrHide();
+        } else {
+            $( showOrHide );
         }
     });