Make WordPress Core

Changeset 61392


Ignore:
Timestamp:
12/18/2025 09:56:44 PM (10 months ago)
Author:
SergeyBiryukov
Message:

Tests: Use assertEqualHTML() in styles HTML tests.

This aims to make the tests more robust.

Follow-up to [287/tests], [749/tests], [25786], [31031], [36550], [46164], [48937], [52036], [61084], [61391].

Props jonsurrell.
See #64225.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/dependencies/styles.php

    r61323 r61392  
    6969                $expected .= "<link rel='stylesheet' id='no-deps-null-version-print-media-css' href='http://example.com' type='text/css' media='print' />\n";
    7070
    71                 $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
     71                $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    7272
    7373                // No styles left to print.
    … …  
    8989                $expected = "<link rel='stylesheet' id='no-deps-no-version-css' href='http://example.com?ver=$ver' media='all' />\n";
    9090
    91                 $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
     91                $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    9292        }
    9393
    … …  
    104104                $expected = "<link rel='stylesheet' id='$handle-css' href='http://example.com' type='text/css' media='all' />\n";
    105105
    106                 $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
     106                $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    107107        }
    108108
    … …  
    158158
    159159                // Go!
    160                 $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
     160                $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    161161
    162162                // No styles left to print.
    … …  
    187187                wp_add_inline_style( 'handle', $style );
    188188
    189                 // No styles left to print.
    190                 $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
     189                $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    191190        }
    192191
    … …  
    216215
    217216                wp_print_styles();
    218                 $this->assertSame( $expected, $wp_styles->print_html );
     217                $this->assertEqualHTML( $expected, $wp_styles->print_html );
    219218        }
    220219
    … …  
    234233         */
    235234        public function test_normalize_relative_css_links( $css, $expected ) {
    236                 $this->assertSame(
     235                $this->assertEqualHTML(
    237236                        $expected,
    238237                        _wp_normalize_relative_css_links( $css, site_url( 'wp-content/themes/test/style.css' ) )
    … …  
    312311                wp_add_inline_style( 'handle', $style2 );
    313312
    314                 // No styles left to print.
    315                 $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
     313                $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    316314        }
    317315
    … …  
    338336                wp_add_inline_style( 'handle', "<style>{$style}</style>" );
    339337
    340                 $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
     338                $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    341339        }
    342340
    … …  
    352350                wp_enqueue_style( 'handle', 'http://example.com', array(), 1 );
    353351
    354                 $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
     352                $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    355353        }
    356354
    … …  
    362360         */
    363361        public function test_conditional_inline_styles_are_also_conditional() {
    364                 $expected = '';
    365362                wp_enqueue_style( 'handle', 'http://example.com', array(), 1 );
    366363                wp_style_add_data( 'handle', 'conditional', 'IE' );
    367364                wp_add_inline_style( 'handle', 'a { color: blue; }' );
    368365
    369                 $this->assertSameIgnoreEOL( $expected, get_echo( 'wp_print_styles' ) );
     366                // Conditional styles are disabled.
     367                $this->assertSame( '', get_echo( 'wp_print_styles' ) );
    370368        }
    371369
    … …  
    400398                wp_add_inline_style( 'handle-three', $style );
    401399
    402                 $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
     400                $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    403401        }
    404402
Note: See TracChangeset for help on using the changeset viewer.