Changeset 61403 for trunk/src/wp-includes/class-wp-query.php

Timestamp:

12/22/2025 11:12:59 PM (8 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace some isset() ternary checks with null coalescing.

Since PHP 7.0 introduced the ​null coalescing operator, and WordPress now requires at least PHP 7.2.24, isset( $var ) ? $var : null ternary checks can be safely replaced with the more concise $var ?? null syntax.

As some new code using the null coalescing operator has already been introduced into core in recent releases, this commit continues with the code modernization by implementing incremental changes for easier review.

Props seanwei, getsyash, krupalpanchal, wildworks, jorbin, SergeyBiryukov.
Fixes #63430. See #58874.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -3020 +3020 @@
                         $clauses = (array) apply_filters_ref_array( 'posts_clauses', array( compact( $pieces ), &$this ) );
 
-                        $where    = isset( $clauses['where'] ) ? $clauses['where'] : '';
-                        $groupby  = isset( $clauses['groupby'] ) ? $clauses['groupby'] : '';
-                        $join     = isset( $clauses['join'] ) ? $clauses['join'] : '';
-                        $orderby  = isset( $clauses['orderby'] ) ? $clauses['orderby'] : '';
-                        $distinct = isset( $clauses['distinct'] ) ? $clauses['distinct'] : '';
-                        $fields   = isset( $clauses['fields'] ) ? $clauses['fields'] : '';
-                        $limits   = isset( $clauses['limits'] ) ? $clauses['limits'] : '';
+                        $where    = $clauses['where'] ?? '';
+                        $groupby  = $clauses['groupby'] ?? '';
+                        $join     = $clauses['join'] ?? '';
+                        $orderby  = $clauses['orderby'] ?? '';
+                        $distinct = $clauses['distinct'] ?? '';
+                        $fields   = $clauses['fields'] ?? '';
+                        $limits   = $clauses['limits'] ?? '';
                 }
 
@@ -3154 +3154 @@
                         $clauses = (array) apply_filters_ref_array( 'posts_clauses_request', array( compact( $pieces ), &$this ) );
 
-                        $where    = isset( $clauses['where'] ) ? $clauses['where'] : '';
-                        $groupby  = isset( $clauses['groupby'] ) ? $clauses['groupby'] : '';
-                        $join     = isset( $clauses['join'] ) ? $clauses['join'] : '';
-                        $orderby  = isset( $clauses['orderby'] ) ? $clauses['orderby'] : '';
-                        $distinct = isset( $clauses['distinct'] ) ? $clauses['distinct'] : '';
-                        $fields   = isset( $clauses['fields'] ) ? $clauses['fields'] : '';
-                        $limits   = isset( $clauses['limits'] ) ? $clauses['limits'] : '';
+                        $where    = $clauses['where'] ?? '';
+                        $groupby  = $clauses['groupby'] ?? '';
+                        $join     = $clauses['join'] ?? '';
+                        $orderby  = $clauses['orderby'] ?? '';
+                        $distinct = $clauses['distinct'] ?? '';
+                        $fields   = $clauses['fields'] ?? '';
+                        $limits   = $clauses['limits'] ?? '';
                 }