Changeset 61416 for trunk/tests/phpunit/tests/dependencies/styles.php

Timestamp:

12/29/2025 06:59:20 PM (10 months ago)

Author:

westonruter

Message:

Script Loader: Warn when a registered style has invalid path data and allow inlining empty stylesheets.

When a stylesheet is registered with a path that does not exist or which is not readable, then a _doing_it_wrong() is now issued. Previously, paths that did not exist were silently skipped; paths for empty styles were also needlessly skipped, since wp_filesize() also returns 0 for the failure case.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10653

Follow-up to [50836].

Props westonruter, jonsurrell, soyebsalar01.
See #52620.
Fixes #64447.

File:

• trunk/tests/phpunit/tests/dependencies/styles.php (modified) (2 diffs)

trunk/tests/phpunit/tests/dependencies/styles.php

@@ -717 +717 @@
         /**
          * @ticket 58394
+         * @ticket 64447
          *
          * @covers ::wp_maybe_inline_styles
-         */
-        public function test_test_wp_maybe_inline_styles_missing_file() {
+         * @expectedIncorrectUsage wp_maybe_inline_styles
+         */
+        public function test_wp_maybe_inline_styles_missing_file() {
                 $filter = new MockAction();
                 add_filter( 'pre_wp_filesize', array( $filter, 'filter' ) );
@@ -767 +769 @@
 
                 $this->assertSame( $GLOBALS['wp_styles']->registered['test-handle']->src, $url );
+        }
+
+        /**
+         * @ticket 64447
+         *
+         * @covers ::wp_maybe_inline_styles
+         * @expectedIncorrectUsage wp_maybe_inline_styles
+         */
+        public function test_wp_maybe_inline_styles_bad_path_with_file_size_provided() {
+                $style_path = '/css/invalid.css'; // Does not exist.
+
+                // This ensures the initial file size check is bypassed.
+                add_filter(
+                        'pre_wp_filesize',
+                        static function ( $size, $path ) use ( $style_path ) {
+                                if ( str_contains( $path, $style_path ) ) {
+                                        $size = 1000;
+                                }
+                                return $size;
+                        },
+                        10,
+                        2
+                );
+
+                $handle = 'test-handle';
+                $url    = '/' . WPINC . $style_path;
+                wp_register_style( $handle, $url );
+                wp_style_add_data( $handle, 'path', ABSPATH . WPINC . $style_path );
+                wp_enqueue_style( $handle );
+
+                wp_maybe_inline_styles();
+
+                $this->assertSame( $GLOBALS['wp_styles']->registered[ $handle ]->src, $url );
+        }
+
+        /**
+         * @ticket 64447
+         *
+         * @covers ::wp_maybe_inline_styles
+         */
+        public function test_wp_maybe_inline_styles_good_path_with_zero_file_size_provided() {
+                $style_path = '/css/classic-themes.css';
+
+                // This simulates the file having a zero size.
+                add_filter(
+                        'pre_wp_filesize',
+                        static function ( $size, $path ) use ( $style_path ) {
+                                if ( str_contains( $path, $style_path ) ) {
+                                        $size = 0;
+                                }
+                                return $size;
+                        },
+                        10,
+                        2
+                );
+
+                $handle = 'test-handle';
+                wp_register_style( $handle, '/' . WPINC . $style_path );
+                wp_style_add_data( $handle, 'path', ABSPATH . WPINC . $style_path );
+                wp_enqueue_style( $handle );
+
+                wp_maybe_inline_styles();
+
+                $this->assertFalse( $GLOBALS['wp_styles']->registered[ $handle ]->src );
         }