Changeset 61420

Timestamp:

12/31/2025 07:00:23 PM (5 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in populate_network() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [60954].

See #64324.

File:

• trunk/tests/phpunit/tests/multisite/populateNetworkHooks.php (modified) (1 diff)

trunk/tests/phpunit/tests/multisite/populateNetworkHooks.php

@@ -60 +60 @@
             $this->assertSame( 1, $this->action_counts['after_populate_network'], 'after_populate_network action should fire once' );
 
-            $this->assertEquals( $network_id, $this->action_args['before_populate_network']['network_id'], 'Network ID should match in before_populate_network hook' );
-            $this->assertEquals( $domain, $this->action_args['before_populate_network']['domain'], 'Domain should match in before_populate_network hook' );
-            $this->assertEquals( $network_id, $this->action_args['after_populate_network']['network_id'], 'Network ID should match in after_populate_network hook' );
-            $this->assertEquals( $domain, $this->action_args['after_populate_network']['domain'], 'Domain should match in after_populate_network hook' );
+            $this->assertSame( $network_id, $this->action_args['before_populate_network']['network_id'], 'Network ID should match in before_populate_network hook' );
+            $this->assertSame( $domain, $this->action_args['before_populate_network']['domain'], 'Domain should match in before_populate_network hook' );
+            $this->assertSame( $network_id, $this->action_args['after_populate_network']['network_id'], 'Network ID should match in after_populate_network hook' );
+            $this->assertSame( $domain, $this->action_args['after_populate_network']['domain'], 'Domain should match in after_populate_network hook' );
 
             remove_action( 'before_populate_network', array( $this, 'hook_action_counter' ), 10 );