Changeset 61425

Timestamp:

01/03/2026 07:15:32 AM (4 months ago)

Author:

westonruter

Message:

Script Loader: Simplify data structure in wp_default_packages_vendor() to facilitate static analysis.

This resolves two PHPStan level 7 issues: offsetAccess.notFound and argument.type.

Follow-up to [44114].

See #64238, #45065.

File:

• trunk/src/wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/wp-includes/script-loader.php

@@ -89 +89 @@
 
     $vendor_scripts = array(
-        'react',
-        'react-dom'         => array( 'react' ),
-        'react-jsx-runtime' => array( 'react' ),
-        'regenerator-runtime',
-        'moment',
-        'lodash',
-        'wp-polyfill-fetch',
-        'wp-polyfill-formdata',
-        'wp-polyfill-node-contains',
-        'wp-polyfill-url',
-        'wp-polyfill-dom-rect',
-        'wp-polyfill-element-closest',
-        'wp-polyfill-object-fit',
-        'wp-polyfill-inert',
-        'wp-polyfill',
+        'react'                       => array(),
+        'react-dom'                   => array( 'react' ),
+        'react-jsx-runtime'           => array( 'react' ),
+        'regenerator-runtime'         => array(),
+        'moment'                      => array(),
+        'lodash'                      => array(),
+        'wp-polyfill-fetch'           => array(),
+        'wp-polyfill-formdata'        => array(),
+        'wp-polyfill-node-contains'   => array(),
+        'wp-polyfill-url'             => array(),
+        'wp-polyfill-dom-rect'        => array(),
+        'wp-polyfill-element-closest' => array(),
+        'wp-polyfill-object-fit'      => array(),
+        'wp-polyfill-inert'           => array(),
+        'wp-polyfill'                 => array(),
     );
 
@@ -125 +125 @@
 
     foreach ( $vendor_scripts as $handle => $dependencies ) {
-        if ( is_string( $dependencies ) ) {
-            $handle       = $dependencies;
-            $dependencies = array();
-        }
-
-        $path    = "/wp-includes/js/dist/vendor/$handle$suffix.js";
-        $version = $vendor_scripts_versions[ $handle ];
-
-        $scripts->add( $handle, $path, $dependencies, $version, 1 );
+        $scripts->add(
+            $handle,
+            "/wp-includes/js/dist/vendor/$handle$suffix.js",
+            $dependencies,
+            $vendor_scripts_versions[ $handle ],
+            1
+        );
     }