Context Navigation

← Previous Change
Next Change →

class-wp-rest-sidebars-controller.php

Timestamp:

01/05/2026 04:31:14 AM (7 months ago)

Author:

westonruter

Message:

Code Modernization: REST API: Use null coalescing operator in place of isset() in ternaries.

Developed as a subset of https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61424], [61404], [61403].

Props costdev, westonruter.
See #58874, #63430.

File:

: 1 edited

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php

-              r59970
+              r61429
                         $sidebar['status']        = 'active';
                         $sidebar['name']          = isset( $registered_sidebar['name'] ) ? $registered_sidebar['name'] : '';
+                        $sidebar['name']          = $registered_sidebar['name'] ?? '';
                         $sidebar['description']   = isset( $registered_sidebar['description'] ) ? wp_sidebar_description( $id ) : '';
                         $sidebar['class']         = isset( $registered_sidebar['class'] ) ? $registered_sidebar['class'] : '';
                         $sidebar['before_widget'] = isset( $registered_sidebar['before_widget'] ) ? $registered_sidebar['before_widget'] : '';
                         $sidebar['after_widget']  = isset( $registered_sidebar['after_widget'] ) ? $registered_sidebar['after_widget'] : '';
                         $sidebar['before_title']  = isset( $registered_sidebar['before_title'] ) ? $registered_sidebar['before_title'] : '';
                         $sidebar['after_title']   = isset( $registered_sidebar['after_title'] ) ? $registered_sidebar['after_title'] : '';
+                        $sidebar['class']         = $registered_sidebar['class'] ?? '';
+                        $sidebar['before_widget'] = $registered_sidebar['before_widget'] ?? '';
+                        $sidebar['after_widget']  = $registered_sidebar['after_widget'] ?? '';
+                        $sidebar['before_title']  = $registered_sidebar['before_title'] ?? '';
+                        $sidebar['after_title']   = $registered_sidebar['after_title'] ?? '';
                 } else {
                         $sidebar['status']      = 'inactive';
 …
                         $sidebars = wp_get_sidebars_widgets();
                         $widgets  = array_filter(
                                 isset( $sidebars[ $sidebar['id'] ] ) ? $sidebars[ $sidebar['id'] ] : array(),
+                                $sidebars[ $sidebar['id'] ] ?? array(),
                                 static function ( $widget_id ) use ( $wp_registered_widgets ) {
                                         return isset( $wp_registered_widgets[ $widget_id ] );

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 61429 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php

Legend:

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php

Download in other formats: