Changeset 61434

Timestamp:

01/05/2026 05:51:15 AM (9 months ago)

Author:

westonruter

Message:

Code Modernization: Comments: Use null coalescing operator instead of isset() ternaries.

Developed as a subset of ​https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in ​https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403].

Props costdev, westonruter.
See #58874, #63430.

Location:

trunk/src

Files:

• wp-admin/edit-comments.php (modified) (2 diffs)
• wp-admin/includes/class-wp-comments-list-table.php (modified) (3 diffs)
• wp-includes/comment.php (modified) (3 diffs)

trunk/src/wp-admin/edit-comments.php

@@ -338 +338 @@
 
                 if ( $spammed > 0 ) {
-                        $ids = isset( $_REQUEST['ids'] ) ? $_REQUEST['ids'] : 0;
+                        $ids = $_REQUEST['ids'] ?? 0;
 
                         $messages[] = sprintf(
@@ -360 +360 @@
 
                 if ( $trashed > 0 ) {
-                        $ids = isset( $_REQUEST['ids'] ) ? $_REQUEST['ids'] : 0;
+                        $ids = $_REQUEST['ids'] ?? 0;
 
                         $messages[] = sprintf(

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -50 +50 @@
                                 'singular' => 'comment',
                                 'ajax'     => true,
-                                'screen'   => isset( $args['screen'] ) ? $args['screen'] : null,
+                                'screen'   => $args['screen'] ?? null,
                         )
                 );
@@ -94 +94 @@
                 }
 
-                $comment_status = isset( $_REQUEST['comment_status'] ) ? $_REQUEST['comment_status'] : 'all';
+                $comment_status = $_REQUEST['comment_status'] ?? 'all';
 
                 if ( ! in_array( $comment_status, array( 'all', 'mine', 'moderated', 'approved', 'spam', 'trash' ), true ) ) {
@@ -145 +145 @@
 
                 $args = array(
-                        'status'                    => isset( $status_map[ $comment_status ] ) ? $status_map[ $comment_status ] : $comment_status,
+                        'status'                    => $status_map[ $comment_status ] ?? $comment_status,
                         'search'                    => $search,
                         'user_id'                   => $user_id,

trunk/src/wp-includes/comment.php

@@ -2216 +2216 @@
          * @param string $comment_agent The comment author's browser user agent.
          */
-        $commentdata['comment_agent'] = apply_filters( 'pre_comment_user_agent', ( isset( $commentdata['comment_agent'] ) ? $commentdata['comment_agent'] : '' ) );
+        $commentdata['comment_agent'] = apply_filters( 'pre_comment_user_agent', ( $commentdata['comment_agent'] ?? '' ) );
         /** This filter is documented in wp-includes/comment.php */
         $commentdata['comment_author'] = apply_filters( 'pre_comment_author_name', $commentdata['comment_author'] );
@@ -2334 +2334 @@
 
         if ( ! isset( $commentdata['comment_agent'] ) ) {
-                $commentdata['comment_agent'] = isset( $_SERVER['HTTP_USER_AGENT'] ) ? $_SERVER['HTTP_USER_AGENT'] : '';
+                $commentdata['comment_agent'] = $_SERVER['HTTP_USER_AGENT'] ?? '';
         }
 
@@ -2633 +2633 @@
         $filter_comment = false;
         if ( ! has_filter( 'pre_comment_content', 'wp_filter_kses' ) ) {
-                $filter_comment = ! user_can( isset( $comment['user_id'] ) ? $comment['user_id'] : 0, 'unfiltered_html' );
+                $filter_comment = ! user_can( $comment['user_id'] ?? 0, 'unfiltered_html' );
         }