Changeset 61445

Timestamp:

01/06/2026 06:05:20 AM (2 months ago)

Author:

westonruter

Message:

Code Modernization: Taxonomy, Posts/Post Types, Options/Meta APIs, Query, General: Use null coalescing operator instead of isset() ternaries.

Developed as a subset of ​https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in ​https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403].

Props costdev, westonruter.
See #58874, #63430.

Location:

trunk/src

Files:

• wp-admin/includes/class-wp-posts-list-table.php (modified) (3 diffs)
• wp-admin/includes/class-wp-terms-list-table.php (modified) (1 diff)
• wp-admin/includes/post.php (modified) (3 diffs)
• wp-includes/class-wp-meta-query.php (modified) (1 diff)
• wp-includes/class-wp-term.php (modified) (1 diff)
• wp-includes/class-wp.php (modified) (4 diffs)
• wp-includes/functions.php (modified) (6 diffs)
• wp-includes/option.php (modified) (1 diff)
• wp-includes/post-template.php (modified) (3 diffs)
• wp-includes/post.php (modified) (5 diffs)
• wp-includes/revision.php (modified) (1 diff)
• wp-includes/taxonomy.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -77 +77 @@
             array(
                 'plural' => 'posts',
-                'screen' => isset( $args['screen'] ) ? $args['screen'] : null,
+                'screen' => $args['screen'] ?? null,
             )
         );
@@ -532 +532 @@
         }
 
-        $displayed_post_format = isset( $_GET['post_format'] ) ? $_GET['post_format'] : '';
+        $displayed_post_format = $_GET['post_format'] ?? '';
         ?>
         <label for="filter-by-format" class="screen-reader-text">
@@ -1265 +1265 @@
         <div class="post-com-count-wrapper">
         <?php
-            $pending_comments = isset( $this->comment_pending_count[ $post->ID ] ) ? $this->comment_pending_count[ $post->ID ] : 0;
+            $pending_comments = $this->comment_pending_count[ $post->ID ] ?? 0;
 
             $this->comments_bubble( $post->ID, $pending_comments );

trunk/src/wp-admin/includes/class-wp-terms-list-table.php

@@ -42 +42 @@
                 'plural'   => 'tags',
                 'singular' => 'tag',
-                'screen'   => isset( $args['screen'] ) ? $args['screen'] : null,
+                'screen'   => $args['screen'] ?? null,
             )
         );

trunk/src/wp-admin/includes/post.php

@@ -430 +430 @@
         }
 
-        $attachment_data = isset( $post_data['attachments'][ $post_id ] ) ? $post_data['attachments'][ $post_id ] : array();
+        $attachment_data = $post_data['attachments'][ $post_id ] ?? array();
 
         /** This filter is documented in wp-admin/includes/media.php */
@@ -1015 +1015 @@
     $metakeyselect = isset( $_POST['metakeyselect'] ) ? wp_unslash( trim( $_POST['metakeyselect'] ) ) : '';
     $metakeyinput  = isset( $_POST['metakeyinput'] ) ? wp_unslash( trim( $_POST['metakeyinput'] ) ) : '';
-    $metavalue     = isset( $_POST['metavalue'] ) ? $_POST['metavalue'] : '';
+    $metavalue     = $_POST['metavalue'] ?? '';
     if ( is_string( $metavalue ) ) {
         $metavalue = trim( $metavalue );
@@ -2044 +2044 @@
      * this is hooked on inner core hooks where a valid nonce was already checked.
      */
-    $posted_data = isset( $_POST['data']['wp_autosave'] ) ? $_POST['data']['wp_autosave'] : $_POST;
+    $posted_data = $_POST['data']['wp_autosave'] ?? $_POST;
 
     $post_type = get_post_type( $new_autosave['post_parent'] );

trunk/src/wp-includes/class-wp-meta-query.php

@@ -620 +620 @@
 
         // Determine the data type.
-        $_meta_type     = isset( $clause['type'] ) ? $clause['type'] : '';
+        $_meta_type     = $clause['type'] ?? '';
         $meta_type      = $this->get_cast_for_type( $_meta_type );
         $clause['cast'] = $meta_type;

trunk/src/wp-includes/class-wp-term.php

@@ -237 +237 @@
                 $columns = array( 'term_id', 'name', 'slug', 'term_group', 'term_taxonomy_id', 'taxonomy', 'description', 'parent', 'count' );
                 foreach ( $columns as $column ) {
-                    $data->{$column} = isset( $this->{$column} ) ? $this->{$column} : null;
+                    $data->{$column} = $this->{$column} ?? null;
                 }
 

trunk/src/wp-includes/class-wp.php

@@ -168 +168 @@
             $this->did_permalink = true;
 
-            $pathinfo         = isset( $_SERVER['PATH_INFO'] ) ? $_SERVER['PATH_INFO'] : '';
+            $pathinfo         = $_SERVER['PATH_INFO'] ?? '';
             list( $pathinfo ) = explode( '?', $pathinfo );
             $pathinfo         = str_replace( '%', '%25', $pathinfo );
@@ -540 +540 @@
 
         if ( is_singular() ) {
-            $post = isset( $wp_query->post ) ? $wp_query->post : null;
+            $post = $wp_query->post ?? null;
 
             // Only set X-Pingback for single posts that allow pings.
@@ -670 +670 @@
         $GLOBALS['query_string'] = $this->query_string;
         $GLOBALS['posts']        = & $wp_query->posts;
-        $GLOBALS['post']         = isset( $wp_query->post ) ? $wp_query->post : null;
+        $GLOBALS['post']         = $wp_query->post ?? null;
         $GLOBALS['request']      = $wp_query->request;
 
@@ -756 +756 @@
 
             if ( is_singular() ) {
-                $post = isset( $wp_query->post ) ? $wp_query->post : null;
+                $post = $wp_query->post ?? null;
                 $next = '<!--nextpage-->';
 

trunk/src/wp-includes/functions.php

@@ -953 +953 @@
             if ( $headers ) {
                 $len           = isset( $headers['Content-Length'] ) ? (int) $headers['Content-Length'] : 0;
-                $type          = isset( $headers['Content-Type'] ) ? $headers['Content-Type'] : '';
+                $type          = $headers['Content-Type'] ?? '';
                 $allowed_types = array( 'video', 'audio' );
 
@@ -3691 +3691 @@
         );
 
-        $redirect_to = isset( $_REQUEST['redirect_to'] ) ? $_REQUEST['redirect_to'] : '';
+        $redirect_to = $_REQUEST['redirect_to'] ?? '';
 
         $html  = $title;
@@ -6140 +6140 @@
  */
 function is_lighttpd_before_150() {
-    $server_parts    = explode( '/', isset( $_SERVER['SERVER_SOFTWARE'] ) ? $_SERVER['SERVER_SOFTWARE'] : '' );
-    $server_parts[1] = isset( $server_parts[1] ) ? $server_parts[1] : '';
+    $server_parts    = explode( '/', $_SERVER['SERVER_SOFTWARE'] ?? '' );
+    $server_parts[1] = $server_parts[1] ?? '';
 
     return ( 'lighttpd' === $server_parts[0] && -1 === version_compare( $server_parts[1], '1.5.0' ) );
@@ -7122 +7122 @@
         $tortoise
     &&
-        ( $evanescent_hare = isset( $override[ $hare ] ) ? $override[ $hare ] : call_user_func_array( $callback, array_merge( array( $hare ), $callback_args ) ) )
+        ( $evanescent_hare = $override[ $hare ] ?? call_user_func_array( $callback, array_merge( array( $hare ), $callback_args ) ) )
     &&
-        ( $hare = isset( $override[ $evanescent_hare ] ) ? $override[ $evanescent_hare ] : call_user_func_array( $callback, array_merge( array( $evanescent_hare ), $callback_args ) ) )
+        ( $hare = $override[ $evanescent_hare ] ?? call_user_func_array( $callback, array_merge( array( $evanescent_hare ), $callback_args ) ) )
     ) {
         if ( $_return_loop ) {
@@ -7138 +7138 @@
 
         // Increment tortoise by one step.
-        $tortoise = isset( $override[ $tortoise ] ) ? $override[ $tortoise ] : call_user_func_array( $callback, array_merge( array( $tortoise ), $callback_args ) );
+        $tortoise = $override[ $tortoise ] ?? call_user_func_array( $callback, array_merge( array( $tortoise ), $callback_args ) );
     }
 
@@ -7267 +7267 @@
                 $caller[] = "{$call['function']}('{$call['args'][0]}')";
             } elseif ( in_array( $call['function'], array( 'include', 'include_once', 'require', 'require_once' ), true ) ) {
-                $filename = isset( $call['args'][0] ) ? $call['args'][0] : '';
+                $filename = $call['args'][0] ?? '';
                 $caller[] = $call['function'] . "('" . str_replace( $truncate_paths, '', wp_normalize_path( $filename ) ) . "')";
             } else {

trunk/src/wp-includes/option.php

@@ -1756 +1756 @@
     $all_user_settings = get_all_user_settings();
 
-    return isset( $all_user_settings[ $name ] ) ? $all_user_settings[ $name ] : $default_value;
+    return $all_user_settings[ $name ] ?? $default_value;
 }
 

trunk/src/wp-includes/post-template.php

@@ -119 +119 @@
     $post = get_post( $post );
 
-    $post_title = isset( $post->post_title ) ? $post->post_title : '';
-    $post_id    = isset( $post->ID ) ? $post->ID : 0;
+    $post_title = $post->post_title ?? '';
+    $post_id    = $post->ID ?? 0;
 
     if ( ! is_admin() ) {
@@ -192 +192 @@
 
     $post_guid = isset( $post->guid ) ? get_the_guid( $post ) : '';
-    $post_id   = isset( $post->ID ) ? $post->ID : 0;
+    $post_id   = $post->ID ?? 0;
 
     /**
@@ -222 +222 @@
     $post = get_post( $post );
 
-    $post_guid = isset( $post->guid ) ? $post->guid : '';
-    $post_id   = isset( $post->ID ) ? $post->ID : 0;
+    $post_guid = $post->guid ?? '';
+    $post_id   = $post->ID ?? 0;
 
     /**

trunk/src/wp-includes/post.php

@@ -2202 +2202 @@
 
     if ( ! isset( $data_object->labels['name_admin_bar'] ) ) {
-        $data_object->labels['name_admin_bar'] =
-            isset( $data_object->labels['singular_name'] )
-            ? $data_object->labels['singular_name']
-            : $data_object->name;
+        $data_object->labels['name_admin_bar'] = $data_object->labels['singular_name'] ?? $data_object->name;
     }
 
@@ -2857 +2854 @@
     $custom = get_post_custom( $post_id );
 
-    return isset( $custom[ $key ] ) ? $custom[ $key ] : null;
+    return $custom[ $key ] ?? null;
 }
 
@@ -4731 +4728 @@
     // These variables are needed by compact() later.
     $post_content_filtered = $postarr['post_content_filtered'];
-    $post_author           = isset( $postarr['post_author'] ) ? $postarr['post_author'] : $user_id;
+    $post_author           = $postarr['post_author'] ?? $user_id;
     $ping_status           = empty( $postarr['ping_status'] ) ? get_default_comment_status( $post_type, 'pingback' ) : $postarr['ping_status'];
     $to_ping               = isset( $postarr['to_ping'] ) ? sanitize_trackback_urls( $postarr['to_ping'] ) : '';
-    $pinged                = isset( $postarr['pinged'] ) ? $postarr['pinged'] : '';
-    $import_id             = isset( $postarr['import_id'] ) ? $postarr['import_id'] : 0;
+    $pinged                = $postarr['pinged'] ?? '';
+    $import_id             = $postarr['import_id'] ?? 0;
 
     /*
@@ -4747 +4744 @@
     }
 
-    $post_password = isset( $postarr['post_password'] ) ? $postarr['post_password'] : '';
+    $post_password = $postarr['post_password'] ?? '';
     if ( 'private' === $post_status ) {
         $post_password = '';
@@ -4816 +4813 @@
 
     // Don't unslash.
-    $post_mime_type = isset( $postarr['post_mime_type'] ) ? $postarr['post_mime_type'] : '';
+    $post_mime_type = $postarr['post_mime_type'] ?? '';
 
     // Expected_slashed (everything!).

trunk/src/wp-includes/revision.php

@@ -90 +90 @@
     $revision_data['post_type']     = 'revision';
     $revision_data['post_name']     = $autosave ? "$post[ID]-autosave-v1" : "$post[ID]-revision-v1"; // "1" is the revisioning system version.
-    $revision_data['post_date']     = isset( $post['post_modified'] ) ? $post['post_modified'] : '';
-    $revision_data['post_date_gmt'] = isset( $post['post_modified_gmt'] ) ? $post['post_modified_gmt'] : '';
+    $revision_data['post_date']     = $post['post_modified'] ?? '';
+    $revision_data['post_date_gmt'] = $post['post_modified_gmt'] ?? '';
 
     return $revision_data;

trunk/src/wp-includes/taxonomy.php

@@ -1724 +1724 @@
     $do_object = is_object( $term );
 
-    $term_id = $do_object ? $term->term_id : ( isset( $term['term_id'] ) ? $term['term_id'] : 0 );
+    $term_id = $do_object ? $term->term_id : ( $term['term_id'] ?? 0 );
 
     foreach ( (array) $fields as $field ) {
@@ -3281 +3281 @@
     $parsed_args['slug'] = $slug;
 
-    $term_group = isset( $parsed_args['term_group'] ) ? $parsed_args['term_group'] : 0;
+    $term_group = $parsed_args['term_group'] ?? 0;
     if ( $args['alias_of'] ) {
         $alias = get_term_by( 'slug', $args['alias_of'], $taxonomy );