Changeset 61451

Timestamp:

01/08/2026 06:29:27 PM (7 months ago)

Author:

SergeyBiryukov

Message:

Tests: Refactor is_email() tests to use a data provider.

Follow-up to [121/tests], [401/tests].

Props salcode, geekofshire, swissspidy, iseulde, miqrogroove, SergeyBiryukov.
Fixes #31313.

File:

• trunk/tests/phpunit/tests/formatting/isEmail.php (modified) (3 diffs)

trunk/tests/phpunit/tests/formatting/isEmail.php

@@ -7 +7 @@
  */
 class Tests_Formatting_IsEmail extends WP_UnitTestCase {
-        public function test_returns_the_email_address_if_it_is_valid() {
-                $data = array(
+
+        /**
+         * @dataProvider valid_email_provider
+         */
+        public function test_returns_the_email_address_if_it_is_valid( $email ) {
+                $this->assertSame( $email, is_email( $email ), "is_email() should return the email address for $email." );
+        }
+
+        /**
+         * Data provider for valid email addresses.
+         *
+         * @return array
+         */
+        public static function valid_email_provider() {
+                $valid_emails = array(
                         'bob@example.com',
                         'phil@example.info',
@@ -16 +29 @@
                         'bill+ted@example.com',
                 );
-                foreach ( $data as $datum ) {
-                        $this->assertSame( $datum, is_email( $datum ), $datum );
+
+                foreach ( $valid_emails as $email ) {
+                        yield $email => array( $email );
                 }
         }
 
-        public function test_returns_false_if_given_an_invalid_email_address() {
-                $data = array(
+        /**
+         * @dataProvider invalid_email_provider
+         */
+        public function test_returns_false_if_given_an_invalid_email_address( $email ) {
+                $this->assertFalse( is_email( $email ), "is_email() should return false for $email." );
+        }
+
+        /**
+         * Data provider for invalid email addresses.
+         *
+         * @return array
+         */
+        public static function invalid_email_provider() {
+                $invalid_emails = array(
                         'khaaaaaaaaaaaaaaan!',
                         'http://bob.example.com/',
@@ -30 +56 @@
                         'a@b.c',
                 );
-                foreach ( $data as $datum ) {
-                        $this->assertFalse( is_email( $datum ), $datum );
+
+                foreach ( $invalid_emails as $email ) {
+                        yield $email => array( $email );
                 }
         }