Changeset 61454 for trunk/src/wp-admin/includes/nav-menu.php

Timestamp:

01/09/2026 02:38:07 AM (9 months ago)

Author:

westonruter

Message:

Code Modernization: Menus, Template, XML-RPC: Use null coalescing operator instead of isset() ternaries.

Developed as a subset of ​https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in ​https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403].

Props costdev, westonruter.
See #58874, #63430.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (3 diffs)

trunk/src/wp-admin/includes/nav-menu.php

@@ -23 +23 @@
 function _wp_ajax_menu_quick_search( $request = array() ) {
         $args            = array();
-        $type            = isset( $request['type'] ) ? $request['type'] : '';
-        $object_type     = isset( $request['object_type'] ) ? $request['object_type'] : '';
-        $query           = isset( $request['q'] ) ? $request['q'] : '';
-        $response_format = isset( $request['response-format'] ) ? $request['response-format'] : '';
+        $type            = $request['type'] ?? '';
+        $object_type     = $request['object_type'] ?? '';
+        $query           = $request['q'] ?? '';
+        $response_format = $request['response-format'] ?? '';
 
         if ( ! $response_format || ! in_array( $response_format, array( 'json', 'markup' ), true ) ) {
@@ -1184 +1184 @@
 
                         $args = array(
-                                'menu-item-db-id'       => ( isset( $_item_object_data['menu-item-db-id'] ) ? $_item_object_data['menu-item-db-id'] : '' ),
-                                'menu-item-object-id'   => ( isset( $_item_object_data['menu-item-object-id'] ) ? $_item_object_data['menu-item-object-id'] : '' ),
-                                'menu-item-object'      => ( isset( $_item_object_data['menu-item-object'] ) ? $_item_object_data['menu-item-object'] : '' ),
-                                'menu-item-parent-id'   => ( isset( $_item_object_data['menu-item-parent-id'] ) ? $_item_object_data['menu-item-parent-id'] : '' ),
-                                'menu-item-position'    => ( isset( $_item_object_data['menu-item-position'] ) ? $_item_object_data['menu-item-position'] : '' ),
-                                'menu-item-type'        => ( isset( $_item_object_data['menu-item-type'] ) ? $_item_object_data['menu-item-type'] : '' ),
-                                'menu-item-title'       => ( isset( $_item_object_data['menu-item-title'] ) ? $_item_object_data['menu-item-title'] : '' ),
-                                'menu-item-url'         => ( isset( $_item_object_data['menu-item-url'] ) ? $_item_object_data['menu-item-url'] : '' ),
-                                'menu-item-description' => ( isset( $_item_object_data['menu-item-description'] ) ? $_item_object_data['menu-item-description'] : '' ),
-                                'menu-item-attr-title'  => ( isset( $_item_object_data['menu-item-attr-title'] ) ? $_item_object_data['menu-item-attr-title'] : '' ),
-                                'menu-item-target'      => ( isset( $_item_object_data['menu-item-target'] ) ? $_item_object_data['menu-item-target'] : '' ),
-                                'menu-item-classes'     => ( isset( $_item_object_data['menu-item-classes'] ) ? $_item_object_data['menu-item-classes'] : '' ),
-                                'menu-item-xfn'         => ( isset( $_item_object_data['menu-item-xfn'] ) ? $_item_object_data['menu-item-xfn'] : '' ),
+                                'menu-item-db-id'       => $_item_object_data['menu-item-db-id'] ?? '',
+                                'menu-item-object-id'   => $_item_object_data['menu-item-object-id'] ?? '',
+                                'menu-item-object'      => $_item_object_data['menu-item-object'] ?? '',
+                                'menu-item-parent-id'   => $_item_object_data['menu-item-parent-id'] ?? '',
+                                'menu-item-position'    => $_item_object_data['menu-item-position'] ?? '',
+                                'menu-item-type'        => $_item_object_data['menu-item-type'] ?? '',
+                                'menu-item-title'       => $_item_object_data['menu-item-title'] ?? '',
+                                'menu-item-url'         => $_item_object_data['menu-item-url'] ?? '',
+                                'menu-item-description' => $_item_object_data['menu-item-description'] ?? '',
+                                'menu-item-attr-title'  => $_item_object_data['menu-item-attr-title'] ?? '',
+                                'menu-item-target'      => $_item_object_data['menu-item-target'] ?? '',
+                                'menu-item-classes'     => $_item_object_data['menu-item-classes'] ?? '',
+                                'menu-item-xfn'         => $_item_object_data['menu-item-xfn'] ?? '',
                         );
 
@@ -1448 +1448 @@
                         $args = array();
                         foreach ( $post_fields as $field ) {
-                                $args[ $field ] = isset( $_POST[ $field ][ $_key ] ) ? $_POST[ $field ][ $_key ] : '';
+                                $args[ $field ] = $_POST[ $field ][ $_key ] ?? '';
                         }