Changeset 61455 for trunk/src/wp-admin/includes/class-plugin-upgrader.php

Timestamp:

01/09/2026 02:46:30 AM (3 months ago)

Author:

westonruter

Message:

Code Modernization: Upgrade/Install: Use null coalescing operator instead of isset() ternaries.

Developed as a subset of ​https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in ​https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403].

Props costdev, westonruter.
See #58874, #63430.

File:

• trunk/src/wp-admin/includes/class-plugin-upgrader.php (modified) (5 diffs)

trunk/src/wp-admin/includes/class-plugin-upgrader.php

@@ -491 +491 @@
         }
 
-        $requires_php = isset( $new_plugin_data['RequiresPHP'] ) ? $new_plugin_data['RequiresPHP'] : null;
-        $requires_wp  = isset( $new_plugin_data['RequiresWP'] ) ? $new_plugin_data['RequiresWP'] : null;
+        $requires_php = $new_plugin_data['RequiresPHP'] ?? null;
+        $requires_wp  = $new_plugin_data['RequiresWP'] ?? null;
 
         if ( ! is_php_version_compatible( $requires_php ) ) {
@@ -571 +571 @@
         }
 
-        $plugin = isset( $plugin['plugin'] ) ? $plugin['plugin'] : '';
+        $plugin = $plugin['plugin'] ?? '';
         if ( empty( $plugin ) ) {
             return new WP_Error( 'bad_request', $this->strings['bad_request'] );
@@ -605 +605 @@
         }
 
-        $plugin = isset( $plugin['plugin'] ) ? $plugin['plugin'] : '';
+        $plugin = $plugin['plugin'] ?? '';
 
         // Only run if plugin is active.
@@ -641 +641 @@
         }
 
-        $plugin = isset( $plugin['plugin'] ) ? $plugin['plugin'] : '';
+        $plugin = $plugin['plugin'] ?? '';
 
         // Only run if plugin is active.
@@ -680 +680 @@
         }
 
-        $plugin = isset( $plugin['plugin'] ) ? $plugin['plugin'] : '';
+        $plugin = $plugin['plugin'] ?? '';
         if ( empty( $plugin ) ) {
             return new WP_Error( 'bad_request', $this->strings['bad_request'] );