Context Navigation

← Previous Change
Next Change →

file.php

Timestamp:

01/09/2026 04:20:21 AM (6 months ago)

Author:

westonruter

Message:

Code Modernization: Administration: Use null coalescing operator instead of isset() ternaries.

Developed as a subset of https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61455], [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403].

Props costdev, westonruter.
See #58874, #63430.

File:

: 1 edited

trunk/src/wp-admin/includes/file.php (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-admin/includes/file.php

-              r61375
+              r61456
         // All tests are on by default. Most can be turned off by $overrides[{test_name}] = false;
         $test_form = isset( $overrides['test_form'] ) ? $overrides['test_form'] : true;
         $test_size = isset( $overrides['test_size'] ) ? $overrides['test_size'] : true;
+        $test_form = $overrides['test_form'] ?? true;
+        $test_size = $overrides['test_size'] ?? true;
         // If you override this, you must provide $ext and $type!!
         $test_type = isset( $overrides['test_type'] ) ? $overrides['test_type'] : true;
         $mimes     = isset( $overrides['mimes'] ) ? $overrides['mimes'] : null;
+        $test_type = $overrides['test_type'] ?? true;
+        $mimes     = $overrides['mimes'] ?? null;
         // A correct form post will pass this test.
 …
+        }
         $hostname        = isset( $credentials['hostname'] ) ? $credentials['hostname'] : '';
         $username        = isset( $credentials['username'] ) ? $credentials['username'] : '';
         $public_key      = isset( $credentials['public_key'] ) ? $credentials['public_key'] : '';
         $private_key     = isset( $credentials['private_key'] ) ? $credentials['private_key'] : '';
         $port            = isset( $credentials['port'] ) ? $credentials['port'] : '';
         $connection_type = isset( $credentials['connection_type'] ) ? $credentials['connection_type'] : '';
+        $hostname        = $credentials['hostname'] ?? '';
+        $username        = $credentials['username'] ?? '';
+        $public_key      = $credentials['public_key'] ?? '';
+        $private_key     = $credentials['private_key'] ?? '';
+        $port            = $credentials['port'] ?? '';
+        $connection_type = $credentials['connection_type'] ?? '';
         if ( $error ) {

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 61456 for trunk/src/wp-admin/includes/file.php

Legend:

trunk/src/wp-admin/includes/file.php

Download in other formats: